[Security Solution] Fix rule filters on the Rule Details page #177081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banderror
added
bug
banderror
added
the
impact:medium
|
/ci |
banderror
force-pushed
the
fix-rule-filters-on-details-page
branch
from
df0d9da to
00eacc0
Compare
|
/ci |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
banderror
force-pushed
the
fix-rule-filters-on-details-page
branch
2 times, most recently
from
9541ff3 to
fb67b07
Compare
maximpn
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
@banderror thanks for fixing the bug 👍
I left a couple of minor comments but there is nothing critical.
| .euiBadge__text { | ||
| white-space: pre-wrap !important; | ||
| } | ||
| const FiltersWidthLimiter = styled.div` |
There was a problem hiding this comment.
While Styled Components are legitimate to be used Emotion is preferred (for example see this PR). EUI is migrating to Emotion and usually new code added to Security Solution uses Emotion as well. Usage is the following
import { css } from '@emotion/css';
...
const filtersWidthLimiter = css`
max-width: 600px;
`;
...
<EuiFlexGroup className={filtersWidthLimiter} wrap responsive={false} gutterSize="xs" data-test-subj={dataTestSubj}>
.../public/detection_engine/rule_management/components/rule_details/rule_definition_section.tsx
Outdated
Show resolved
Hide resolved
banderror
force-pushed
the
fix-rule-filters-on-details-page
branch
from
fb67b07 to
28e3349
Compare
|
@maximpn I addressed your comments and enabled auto-merge. Feel free to check it one more time if you're interested. We can push any other improvements separately. Thank you! |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @banderror |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 19, 2024
…c#177081) **Fixes: elastic#141458 **Fixes: elastic#176866 ## Summary Fixes the bugs above by changing the `Filters` component: - from using lower-level components like `FilterBadgeGroup` and custom rendering - to using a higher-level `FilterItems` component that's used inside a larger component `QueryBar` (see the first screenshot below) on the Rule Creation / Editing pages Note that for some reason the end result still does not fully equal to how filters look on the Rule Creation / Editing pages, where there are fewer warnings. It's hard to say which rendering is the right one. ## Screenshots **How filters look on the Rule Creation / Editing pages:** <img width="989" alt="Screenshot 2024-02-15 at 21 25 00" src="https://github.com/elastic/kibana/assets/7359339/01ca468f-be99-469a-8d75-ee5aa1a31fb0"> **Rule Details page BEFORE the fix:** <img width="1792" alt="Screenshot 2024-02-15 at 21 23 46" src="https://github.com/elastic/kibana/assets/7359339/d0e2aa6e-3050-4327-8025-f37125498fd6"> <img width="1792" alt="Screenshot 2024-02-15 at 21 24 02" src="https://github.com/elastic/kibana/assets/7359339/a89302b2-f991-4547-bdac-c0f5a594a881"> <img width="1792" alt="Screenshot 2024-02-15 at 21 24 18" src="https://github.com/elastic/kibana/assets/7359339/49c16b02-8d82-4f93-932f-3846880a0457"> **Rule Details page AFTER the fix 1 (filters use non-existing fields and show warnings):** <img width="1790" alt="Screenshot 2024-02-15 at 21 28 46" src="https://github.com/elastic/kibana/assets/7359339/e229b4ff-6ee7-4444-b5c1-deb00d2b9b39"> **Rule Details page AFTER the fix 2 (filters use existing fields and look normal):** <img width="1792" alt="Screenshot 2024-02-15 at 21 37 45" src="https://github.com/elastic/kibana/assets/7359339/b10905e7-803d-4404-aa02-8692ff964891"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 2672662)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 19, 2024
…177081) (#177242) # Backport This will backport the following commits from `main` to `8.13`: - [[Security Solution] Fix rule filters on the Rule Details page (#177081)](#177081) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgii Gorbachev","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-19T21:26:12Z","message":"[Security Solution] Fix rule filters on the Rule Details page (#177081)\n\n**Fixes: https://github.com/elastic/kibana/issues/141458**\r\n**Fixes: https://github.com/elastic/kibana/issues/176866**\r\n\r\n## Summary\r\n\r\nFixes the bugs above by changing the `Filters` component:\r\n\r\n- from using lower-level components like `FilterBadgeGroup` and custom\r\nrendering\r\n- to using a higher-level `FilterItems` component that's used inside a\r\nlarger component `QueryBar` (see the first screenshot below) on the Rule\r\nCreation / Editing pages\r\n\r\nNote that for some reason the end result still does not fully equal to\r\nhow filters look on the Rule Creation / Editing pages, where there are\r\nfewer warnings. It's hard to say which rendering is the right one.\r\n\r\n## Screenshots\r\n\r\n**How filters look on the Rule Creation / Editing pages:**\r\n\r\n<img width=\"989\" alt=\"Screenshot 2024-02-15 at 21 25 00\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/01ca468f-be99-469a-8d75-ee5aa1a31fb0\">\r\n\r\n**Rule Details page BEFORE the fix:**\r\n\r\n<img width=\"1792\" alt=\"Screenshot 2024-02-15 at 21 23 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/d0e2aa6e-3050-4327-8025-f37125498fd6\">\r\n<img width=\"1792\" alt=\"Screenshot 2024-02-15 at 21 24 02\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/a89302b2-f991-4547-bdac-c0f5a594a881\">\r\n<img width=\"1792\" alt=\"Screenshot 2024-02-15 at 21 24 18\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/49c16b02-8d82-4f93-932f-3846880a0457\">\r\n\r\n**Rule Details page AFTER the fix 1 (filters use non-existing fields and\r\nshow warnings):**\r\n\r\n<img width=\"1790\" alt=\"Screenshot 2024-02-15 at 21 28 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/e229b4ff-6ee7-4444-b5c1-deb00d2b9b39\">\r\n\r\n**Rule Details page AFTER the fix 2 (filters use existing fields and\r\nlook normal):**\r\n\r\n<img width=\"1792\" alt=\"Screenshot 2024-02-15 at 21 37 45\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/b10905e7-803d-4404-aa02-8692ff964891\">\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"26726625394dfc4a5143dd1e1c895487c2f90380","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","impact:medium","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Rule Details","8.13 candidate","v8.13.0","v8.12.2","v8.14.0"],"title":"[Security Solution] Fix rule filters on the Rule Details page","number":177081,"url":"https://github.com/elastic/kibana/pull/177081","mergeCommit":{"message":"[Security Solution] Fix rule filters on the Rule Details page (#177081)\n\n**Fixes: https://github.com/elastic/kibana/issues/141458**\r\n**Fixes: https://github.com/elastic/kibana/issues/176866**\r\n\r\n## Summary\r\n\r\nFixes the bugs above by changing the `Filters` component:\r\n\r\n- from using lower-level components like `FilterBadgeGroup` and custom\r\nrendering\r\n- to using a higher-level `FilterItems` component that's used inside a\r\nlarger component `QueryBar` (see the first screenshot below) on the Rule\r\nCreation / Editing pages\r\n\r\nNote that for some reason the end result still does not fully equal to\r\nhow filters look on the Rule Creation / Editing pages, where there are\r\nfewer warnings. It's hard to say which rendering is the right one.\r\n\r\n## Screenshots\r\n\r\n**How filters look on the Rule Creation / Editing pages:**\r\n\r\n<img width=\"989\" alt=\"Screenshot 2024-02-15 at 21 25 00\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/01ca468f-be99-469a-8d75-ee5aa1a31fb0\">\r\n\r\n**Rule Details page BEFORE the fix:**\r\n\r\n<img width=\"1792\" alt=\"Screenshot 2024-02-15 at 21 23 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/d0e2aa6e-3050-4327-8025-f37125498fd6\">\r\n<img width=\"1792\" alt=\"Screenshot 2024-02-15 at 21 24 02\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/a89302b2-f991-4547-bdac-c0f5a594a881\">\r\n<img width=\"1792\" alt=\"Screenshot 2024-02-15 at 21 24 18\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/49c16b02-8d82-4f93-932f-3846880a0457\">\r\n\r\n**Rule Details page AFTER the fix 1 (filters use non-existing fields and\r\nshow warnings):**\r\n\r\n<img width=\"1790\" alt=\"Screenshot 2024-02-15 at 21 28 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/e229b4ff-6ee7-4444-b5c1-deb00d2b9b39\">\r\n\r\n**Rule Details page AFTER the fix 2 (filters use existing fields and\r\nlook normal):**\r\n\r\n<img width=\"1792\" alt=\"Screenshot 2024-02-15 at 21 37 45\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/b10905e7-803d-4404-aa02-8692ff964891\">\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"26726625394dfc4a5143dd1e1c895487c2f90380"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","8.12"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.12","label":"v8.12.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177081","number":177081,"mergeCommit":{"message":"[Security Solution] Fix rule filters on the Rule Details page (#177081)\n\n**Fixes: https://github.com/elastic/kibana/issues/141458**\r\n**Fixes: https://github.com/elastic/kibana/issues/176866**\r\n\r\n## Summary\r\n\r\nFixes the bugs above by changing the `Filters` component:\r\n\r\n- from using lower-level components like `FilterBadgeGroup` and custom\r\nrendering\r\n- to using a higher-level `FilterItems` component that's used inside a\r\nlarger component `QueryBar` (see the first screenshot below) on the Rule\r\nCreation / Editing pages\r\n\r\nNote that for some reason the end result still does not fully equal to\r\nhow filters look on the Rule Creation / Editing pages, where there are\r\nfewer warnings. It's hard to say which rendering is the right one.\r\n\r\n## Screenshots\r\n\r\n**How filters look on the Rule Creation / Editing pages:**\r\n\r\n<img width=\"989\" alt=\"Screenshot 2024-02-15 at 21 25 00\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/01ca468f-be99-469a-8d75-ee5aa1a31fb0\">\r\n\r\n**Rule Details page BEFORE the fix:**\r\n\r\n<img width=\"1792\" alt=\"Screenshot 2024-02-15 at 21 23 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/d0e2aa6e-3050-4327-8025-f37125498fd6\">\r\n<img width=\"1792\" alt=\"Screenshot 2024-02-15 at 21 24 02\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/a89302b2-f991-4547-bdac-c0f5a594a881\">\r\n<img width=\"1792\" alt=\"Screenshot 2024-02-15 at 21 24 18\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/49c16b02-8d82-4f93-932f-3846880a0457\">\r\n\r\n**Rule Details page AFTER the fix 1 (filters use non-existing fields and\r\nshow warnings):**\r\n\r\n<img width=\"1790\" alt=\"Screenshot 2024-02-15 at 21 28 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/e229b4ff-6ee7-4444-b5c1-deb00d2b9b39\">\r\n\r\n**Rule Details page AFTER the fix 2 (filters use existing fields and\r\nlook normal):**\r\n\r\n<img width=\"1792\" alt=\"Screenshot 2024-02-15 at 21 37 45\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7359339/b10905e7-803d-4404-aa02-8692ff964891\">\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"26726625394dfc4a5143dd1e1c895487c2f90380"}}]}] BACKPORT--> Co-authored-by: Georgii Gorbachev <[email protected]>
banderror
added a commit
to banderror/kibana
that referenced
this pull request
Feb 20, 2024
…c#177081) **Fixes: elastic#141458 **Fixes: elastic#176866 ## Summary Fixes the bugs above by changing the `Filters` component: - from using lower-level components like `FilterBadgeGroup` and custom rendering - to using a higher-level `FilterItems` component that's used inside a larger component `QueryBar` (see the first screenshot below) on the Rule Creation / Editing pages Note that for some reason the end result still does not fully equal to how filters look on the Rule Creation / Editing pages, where there are fewer warnings. It's hard to say which rendering is the right one. ## Screenshots **How filters look on the Rule Creation / Editing pages:** <img width="989" alt="Screenshot 2024-02-15 at 21 25 00" src="https://github.com/elastic/kibana/assets/7359339/01ca468f-be99-469a-8d75-ee5aa1a31fb0"> **Rule Details page BEFORE the fix:** <img width="1792" alt="Screenshot 2024-02-15 at 21 23 46" src="https://github.com/elastic/kibana/assets/7359339/d0e2aa6e-3050-4327-8025-f37125498fd6"> <img width="1792" alt="Screenshot 2024-02-15 at 21 24 02" src="https://github.com/elastic/kibana/assets/7359339/a89302b2-f991-4547-bdac-c0f5a594a881"> <img width="1792" alt="Screenshot 2024-02-15 at 21 24 18" src="https://github.com/elastic/kibana/assets/7359339/49c16b02-8d82-4f93-932f-3846880a0457"> **Rule Details page AFTER the fix 1 (filters use non-existing fields and show warnings):** <img width="1790" alt="Screenshot 2024-02-15 at 21 28 46" src="https://github.com/elastic/kibana/assets/7359339/e229b4ff-6ee7-4444-b5c1-deb00d2b9b39"> **Rule Details page AFTER the fix 2 (filters use existing fields and look normal):** <img width="1792" alt="Screenshot 2024-02-15 at 21 37 45" src="https://github.com/elastic/kibana/assets/7359339/b10905e7-803d-4404-aa02-8692ff964891"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 2672662) # Conflicts: # x-pack/plugins/security_solution/public/detection_engine/rule_management/components/rule_details/rule_definition_section.tsx
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
banderror
added a commit
that referenced
this pull request
Feb 20, 2024
…177081) (#177260) # Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Fix rule filters on the Rule Details page (#177081)](#177081) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)
|
This PR didn't landed on time to be included on v8.12.2. Updating the labels. |
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…c#177081) **Fixes: elastic#141458 **Fixes: elastic#176866 ## Summary Fixes the bugs above by changing the `Filters` component: - from using lower-level components like `FilterBadgeGroup` and custom rendering - to using a higher-level `FilterItems` component that's used inside a larger component `QueryBar` (see the first screenshot below) on the Rule Creation / Editing pages Note that for some reason the end result still does not fully equal to how filters look on the Rule Creation / Editing pages, where there are fewer warnings. It's hard to say which rendering is the right one. ## Screenshots **How filters look on the Rule Creation / Editing pages:** <img width="989" alt="Screenshot 2024-02-15 at 21 25 00" src="https://github.com/elastic/kibana/assets/7359339/01ca468f-be99-469a-8d75-ee5aa1a31fb0"> **Rule Details page BEFORE the fix:** <img width="1792" alt="Screenshot 2024-02-15 at 21 23 46" src="https://github.com/elastic/kibana/assets/7359339/d0e2aa6e-3050-4327-8025-f37125498fd6"> <img width="1792" alt="Screenshot 2024-02-15 at 21 24 02" src="https://github.com/elastic/kibana/assets/7359339/a89302b2-f991-4547-bdac-c0f5a594a881"> <img width="1792" alt="Screenshot 2024-02-15 at 21 24 18" src="https://github.com/elastic/kibana/assets/7359339/49c16b02-8d82-4f93-932f-3846880a0457"> **Rule Details page AFTER the fix 1 (filters use non-existing fields and show warnings):** <img width="1790" alt="Screenshot 2024-02-15 at 21 28 46" src="https://github.com/elastic/kibana/assets/7359339/e229b4ff-6ee7-4444-b5c1-deb00d2b9b39"> **Rule Details page AFTER the fix 2 (filters use existing fields and look normal):** <img width="1792" alt="Screenshot 2024-02-15 at 21 37 45" src="https://github.com/elastic/kibana/assets/7359339/b10905e7-803d-4404-aa02-8692ff964891"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
|
Hi @banderror , In 8.11.1 there is bug with "NOT" filter, I am using "AND" inside the filter.
Thank you :) |
|
@banderror are you sure? it's regular filter not custom label. |
|
@shayfeld Yes, the negation ("NOT") now works correctly for both regular filters and filters with custom labels. Here's an example from the latest 8.13.0 prerelease version: Rule Creation page: 
Rule Details page: 
There's an issue with that |
|
Follow-up issue: #178908 |
banderror
added a commit
that referenced
this pull request
Mar 27, 2024
**Related to:** #177081 ## Summary This PR builds upon some custom CSS introduced in #177081 according to @maximpn's [suggestion](#177081 (comment)). It slightly adjusts the way the styles are defined based on our prior discussion at Tech Time, proposing a canonical way to write custom CSS within the @elastic/security-detection-rule-management team.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 27, 2024
…ic#179282) **Related to:** elastic#177081 ## Summary This PR builds upon some custom CSS introduced in elastic#177081 according to @maximpn's [suggestion](elastic#177081 (comment)). It slightly adjusts the way the styles are defined based on our prior discussion at Tech Time, proposing a canonical way to write custom CSS within the @elastic/security-detection-rule-management team. (cherry picked from commit fb1eb4c)
kibanamachine
added a commit
that referenced
this pull request
Mar 27, 2024
…#179282) (#179531) # Backport This will backport the following commits from `main` to `8.13`: - [[Security Solution] Align on custom CSS within Rule Management (#179282)](#179282) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgii Gorbachev","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-03-27T12:04:29Z","message":"[Security Solution] Align on custom CSS within Rule Management (#179282)\n\n**Related to:** https://github.com/elastic/kibana/pull/177081\r\n\r\n## Summary\r\n\r\nThis PR builds upon some custom CSS introduced in\r\nhttps://github.com//pull/177081 according to @maximpn's\r\n[suggestion](https://github.com/elastic/kibana/pull/177081#discussion_r1494357297).\r\n\r\nIt slightly adjusts the way the styles are defined based on our prior\r\ndiscussion at Tech Time, proposing a canonical way to write custom CSS\r\nwithin the @elastic/security-detection-rule-management team.","sha":"fb1eb4ca191e8d199ffe5a06290cdfe05e3e5a79","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["refactoring","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","v8.14.0","v8.13.1"],"title":"[Security Solution] Align on custom CSS within Rule Management","number":179282,"url":"https://github.com/elastic/kibana/pull/179282","mergeCommit":{"message":"[Security Solution] Align on custom CSS within Rule Management (#179282)\n\n**Related to:** https://github.com/elastic/kibana/pull/177081\r\n\r\n## Summary\r\n\r\nThis PR builds upon some custom CSS introduced in\r\nhttps://github.com//pull/177081 according to @maximpn's\r\n[suggestion](https://github.com/elastic/kibana/pull/177081#discussion_r1494357297).\r\n\r\nIt slightly adjusts the way the styles are defined based on our prior\r\ndiscussion at Tech Time, proposing a canonical way to write custom CSS\r\nwithin the @elastic/security-detection-rule-management team.","sha":"fb1eb4ca191e8d199ffe5a06290cdfe05e3e5a79"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/179282","number":179282,"mergeCommit":{"message":"[Security Solution] Align on custom CSS within Rule Management (#179282)\n\n**Related to:** https://github.com/elastic/kibana/pull/177081\r\n\r\n## Summary\r\n\r\nThis PR builds upon some custom CSS introduced in\r\nhttps://github.com//pull/177081 according to @maximpn's\r\n[suggestion](https://github.com/elastic/kibana/pull/177081#discussion_r1494357297).\r\n\r\nIt slightly adjusts the way the styles are defined based on our prior\r\ndiscussion at Tech Time, proposing a canonical way to write custom CSS\r\nwithin the @elastic/security-detection-rule-management team.","sha":"fb1eb4ca191e8d199ffe5a06290cdfe05e3e5a79"}},{"branch":"8.13","label":"v8.13.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgii Gorbachev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #141458
Fixes: #176866
Fixes: #175306
Summary
Fixes the bugs above by changing the
Filterscomponent:FilterBadgeGroupand custom renderingFilterItemscomponent that's used inside a larger componentQueryBar(see the first screenshot below) on the Rule Creation / Editing pagesNote that for some reason the end result still does not fully equal to how filters look on the Rule Creation / Editing pages, where there are fewer warnings. It's hard to say which rendering is the right one. UPD: could be related to #178908.
Screenshots
How filters look on the Rule Creation / Editing pages:
Rule Details page BEFORE the fix:
Rule Details page AFTER the fix 1 (filters use non-existing fields and show warnings):
Rule Details page AFTER the fix 2 (filters use existing fields and look normal):
Checklist
For maintainers