Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Pipelines] Highlight deprecated pipelines #174814

Merged

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Jan 14, 2024

Partially addresses #170805

Summary

With elastic/elasticsearch#101148 we now can alert the users when an ingest pipeline will soon be deprecated and shouldnt be relied upon. This PR adds a badge and a callout to the ingest pipelines UI to alert the users about this.

How to test
  • Start up kibana and es
  • Navigate to Stack management -> Ingest pipelines
  • Verify that:
    • Deprecated pipelines are hidden by default
    • Upon enabling filtering to see them they should pop up on the table with a badge
    • Verify that deprecated policies are highlighted and when editing, we also show a warning callout.

Screenshot

Screenshot 2024-02-05 at 16 02 18

@sabarasaba sabarasaba added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:Ingest Node Pipelines Ingest node pipelines management v8.13.0 labels Jan 14, 2024
@sabarasaba sabarasaba self-assigned this Jan 14, 2024
@sabarasaba
Copy link
Member Author

/ci

@sabarasaba sabarasaba marked this pull request as ready for review January 14, 2024 12:02
@sabarasaba sabarasaba requested a review from a team as a code owner January 14, 2024 12:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@yuliacech yuliacech self-requested a review January 16, 2024 10:57
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on the deprecated pipelines, @sabarasaba!
Code changes LGTM 👍 I tested locally and the UI works as expected.
The filters are a little confusing for me though: the managed filter is not enabled by default but managed pipelines are shown and the deprecated ones are hidden. So it feels like the same filter buttons don't have the same function. I was trying to hide both managed and deprecated pipelines, but I don't think that is possible at the moment.
I think a more consistent UI for filters would be to mark the "managed" filter as enabled by default and if the user clicks to disable it, hide managed pipelines. That way both filters would work consistently, wdyt?

@sabarasaba
Copy link
Member Author

I was trying to hide both managed and deprecated pipelines, but I don't think that is possible at the moment.

Not with filtering buttons perse, but can be done by negating the query -is:isManaged.

I think a more consistent UI for filters would be to mark the "managed" filter as enabled by default and if the user clicks to disable it, hide managed pipelines. That way both filters would work consistently, wdyt?

This problem arises because we want managed to be shown by default, but deprecated to be hidden by default and they both need to work with the same filtering pattern.

But I think this would make for an odd default behaviour too, since if the managed filter is enabled by default then we would want managed pipelines and non-managed to be shown and the same would need to happen for the deprecated which is strange. I think a way to have them behave consistently while keeping sane defaults would be to have managed hidden by default (although I might be missing something on why we have this enabled by default). So that toggling the filter will show us only those that comply with the filtering option (deprecated|managed). 🤔

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba
Copy link
Member Author

/ci

@yuliacech yuliacech assigned yuliacech and unassigned sabarasaba Feb 5, 2024
@yuliacech yuliacech enabled auto-merge (squash) February 5, 2024 16:05
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for addressing the feedback, @sabarasaba!
I re-tested locally and pushed some changes to make the implementation somewhat easier by filtering the pipelines according to the filters options (managed and deprecated) and leaving the search to be handled by the table.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 362.0KB 364.7KB +2.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yuliacech

@yuliacech yuliacech merged commit 7b297f4 into elastic:main Feb 5, 2024
18 checks passed
fkanout pushed a commit to fkanout/kibana that referenced this pull request Feb 7, 2024
Partially addresses elastic#170805

## Summary

With elastic/elasticsearch#101148 we now can
alert the users when an ingest pipeline will soon be deprecated and
shouldnt be relied upon. This PR adds a badge and a callout to the
ingest pipelines UI to alert the users about this.

##### How to test

* Start up kibana and es
* Navigate to Stack management -> Ingest pipelines
* Verify that:
  * Deprecated pipelines are hidden by default
* Upon enabling filtering to see them they should pop up on the table
with a badge
* Verify that deprecated policies are highlighted and when editing, we
also show a warning callout.

### Screenshot 
<img width="1386" alt="Screenshot 2024-02-05 at 16 02 18"
src="https://github.com/elastic/kibana/assets/6585477/739d6fea-5f15-4da4-aee8-cae8f412a040">

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Yulia Čech <[email protected]>
Co-authored-by: Yulia Cech <[email protected]>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
Partially addresses elastic#170805

## Summary

With elastic/elasticsearch#101148 we now can
alert the users when an ingest pipeline will soon be deprecated and
shouldnt be relied upon. This PR adds a badge and a callout to the
ingest pipelines UI to alert the users about this.

##### How to test

* Start up kibana and es
* Navigate to Stack management -> Ingest pipelines
* Verify that:
  * Deprecated pipelines are hidden by default
* Upon enabling filtering to see them they should pop up on the table
with a badge
* Verify that deprecated policies are highlighted and when editing, we
also show a warning callout.

### Screenshot 
<img width="1386" alt="Screenshot 2024-02-05 at 16 02 18"
src="https://github.com/elastic/kibana/assets/6585477/739d6fea-5f15-4da4-aee8-cae8f412a040">

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Yulia Čech <[email protected]>
Co-authored-by: Yulia Cech <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
Partially addresses elastic#170805

## Summary

With elastic/elasticsearch#101148 we now can
alert the users when an ingest pipeline will soon be deprecated and
shouldnt be relied upon. This PR adds a badge and a callout to the
ingest pipelines UI to alert the users about this.

##### How to test

* Start up kibana and es
* Navigate to Stack management -> Ingest pipelines
* Verify that:
  * Deprecated pipelines are hidden by default
* Upon enabling filtering to see them they should pop up on the table
with a badge
* Verify that deprecated policies are highlighted and when editing, we
also show a warning callout.

### Screenshot 
<img width="1386" alt="Screenshot 2024-02-05 at 16 02 18"
src="https://github.com/elastic/kibana/assets/6585477/739d6fea-5f15-4da4-aee8-cae8f412a040">

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Yulia Čech <[email protected]>
Co-authored-by: Yulia Cech <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants