-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Pipelines] Highlight deprecated pipelines #174814
[Ingest Pipelines] Highlight deprecated pipelines #174814
Conversation
/ci |
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on the deprecated pipelines, @sabarasaba!
Code changes LGTM 👍 I tested locally and the UI works as expected.
The filters are a little confusing for me though: the managed filter is not enabled by default but managed pipelines are shown and the deprecated ones are hidden. So it feels like the same filter buttons don't have the same function. I was trying to hide both managed and deprecated pipelines, but I don't think that is possible at the moment.
I think a more consistent UI for filters would be to mark the "managed" filter as enabled by default and if the user clicks to disable it, hide managed pipelines. That way both filters would work consistently, wdyt?
Not with filtering buttons perse, but can be done by negating the query
This problem arises because we want managed to be shown by default, but deprecated to be hidden by default and they both need to work with the same filtering pattern. But I think this would make for an odd default behaviour too, since if the managed filter is enabled by default then we would want managed pipelines and non-managed to be shown and the same would need to happen for the |
@elasticmachine merge upstream |
/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for addressing the feedback, @sabarasaba!
I re-tested locally and pushed some changes to make the implementation somewhat easier by filtering the pipelines according to the filters options (managed and deprecated) and leaving the search to be handled by the table.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @yuliacech |
Partially addresses elastic#170805 ## Summary With elastic/elasticsearch#101148 we now can alert the users when an ingest pipeline will soon be deprecated and shouldnt be relied upon. This PR adds a badge and a callout to the ingest pipelines UI to alert the users about this. ##### How to test * Start up kibana and es * Navigate to Stack management -> Ingest pipelines * Verify that: * Deprecated pipelines are hidden by default * Upon enabling filtering to see them they should pop up on the table with a badge * Verify that deprecated policies are highlighted and when editing, we also show a warning callout. ### Screenshot <img width="1386" alt="Screenshot 2024-02-05 at 16 02 18" src="https://github.com/elastic/kibana/assets/6585477/739d6fea-5f15-4da4-aee8-cae8f412a040"> --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Yulia Čech <[email protected]> Co-authored-by: Yulia Cech <[email protected]>
Partially addresses elastic#170805 ## Summary With elastic/elasticsearch#101148 we now can alert the users when an ingest pipeline will soon be deprecated and shouldnt be relied upon. This PR adds a badge and a callout to the ingest pipelines UI to alert the users about this. ##### How to test * Start up kibana and es * Navigate to Stack management -> Ingest pipelines * Verify that: * Deprecated pipelines are hidden by default * Upon enabling filtering to see them they should pop up on the table with a badge * Verify that deprecated policies are highlighted and when editing, we also show a warning callout. ### Screenshot <img width="1386" alt="Screenshot 2024-02-05 at 16 02 18" src="https://github.com/elastic/kibana/assets/6585477/739d6fea-5f15-4da4-aee8-cae8f412a040"> --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Yulia Čech <[email protected]> Co-authored-by: Yulia Cech <[email protected]>
Partially addresses elastic#170805 ## Summary With elastic/elasticsearch#101148 we now can alert the users when an ingest pipeline will soon be deprecated and shouldnt be relied upon. This PR adds a badge and a callout to the ingest pipelines UI to alert the users about this. ##### How to test * Start up kibana and es * Navigate to Stack management -> Ingest pipelines * Verify that: * Deprecated pipelines are hidden by default * Upon enabling filtering to see them they should pop up on the table with a badge * Verify that deprecated policies are highlighted and when editing, we also show a warning callout. ### Screenshot <img width="1386" alt="Screenshot 2024-02-05 at 16 02 18" src="https://github.com/elastic/kibana/assets/6585477/739d6fea-5f15-4da4-aee8-cae8f412a040"> --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Yulia Čech <[email protected]> Co-authored-by: Yulia Cech <[email protected]>
Partially addresses #170805
Summary
With elastic/elasticsearch#101148 we now can alert the users when an ingest pipeline will soon be deprecated and shouldnt be relied upon. This PR adds a badge and a callout to the ingest pipelines UI to alert the users about this.
How to test
Screenshot