nit #173214
Merged
nit #173214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
sphilipse
approved these changes
Dec 13, 2023
|
nit: 'nit' isn't a great PR title ;) |
seanstory
added
the
release_note:skip
Merged
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 13, 2023
## Summary reading copy on the new search hub as part of elastic/search-team#6428, noticed some disagreement. ### Checklist ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit e74f60e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 13, 2023
# Backport This will backport the following commits from `main` to `8.12`: - [nit (#173214)](#173214) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sean Story","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-13T14:09:33Z","message":"nit (#173214)\n\n## Summary\r\n\r\nreading copy on the new search hub as part of\r\nhttps://github.com/elastic/search-team/issues/6428, noticed\r\nsome disagreement.\r\n\r\n### Checklist\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e74f60ee4700b10903588f5c528d6162778f0471","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.12.0","v8.13.0"],"number":173214,"url":"https://github.com/elastic/kibana/pull/173214","mergeCommit":{"message":"nit (#173214)\n\n## Summary\r\n\r\nreading copy on the new search hub as part of\r\nhttps://github.com/elastic/search-team/issues/6428, noticed\r\nsome disagreement.\r\n\r\n### Checklist\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e74f60ee4700b10903588f5c528d6162778f0471"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173214","number":173214,"mergeCommit":{"message":"nit (#173214)\n\n## Summary\r\n\r\nreading copy on the new search hub as part of\r\nhttps://github.com/elastic/search-team/issues/6428, noticed\r\nsome disagreement.\r\n\r\n### Checklist\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e74f60ee4700b10903588f5c528d6162778f0471"}}]}] BACKPORT--> Co-authored-by: Sean Story <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
reading copy on the new search hub as part of https://github.com/elastic/enterprise-search-team/issues/6428, noticed some disagreement.
Checklist
For maintainers