-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Make logs-* and metrics-* data views available across all spaces #172991
Conversation
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]
To update your PR or re-run it, just comment with: cc @kpollich |
|
||
results.push(result); | ||
} catch (error) { | ||
logger.error(`Error making managed index patterns global: ${error.message}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this operation gets retried on every setup, there is a possibility this error will appear many times in logs if there is something going wrong with the spaces update operation. Maybe worth moving this to debug
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kpollich what will could make that update fail? any thing that will not be a transient error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if someone manually creates one of these data views with the same title
property before installing any integrations there could be a conflict and that would surface as an error here. Very much an edge case and technically preexisting before this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What happens if a data view created by the user called logs or metrics already exists in the space? Don’t want our dashboards to break again. |
Data views have a globally unique ID that must be unique across all spaces, so there should be no risk of conflict when Fleet marks one as global here. Even if there are multiple Overall, this change should allow users to remove their own |
Summary
Closes #172009
Adds a call to
updateObjectsSpaces
with['*']
as the spaces list after Fleet's managed data views are created.Existing data views will be updated to be global whenever
installKibanaAssets
is called.Checklist