Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs Explorer] Fix discover tab time range test #173198

Merged
merged 3 commits into from
Dec 13, 2023
Merged

[Logs Explorer] Fix discover tab time range test #173198

merged 3 commits into from
Dec 13, 2023

Conversation

weltenwort
Copy link
Member

📝 Summary

This makes the time range used in the Logs Explorer explicit instead of aligning with the test data. That avoids a test failure resulting from a different default data view choice in Discover after #172991.

fixes #173165

@weltenwort weltenwort self-assigned this Dec 12, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@weltenwort weltenwort added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team Feature:LogsExplorer Logs Explorer feature labels Dec 12, 2023
@weltenwort weltenwort marked this pull request as ready for review December 12, 2023 19:28
@weltenwort weltenwort requested a review from a team as a code owner December 12, 2023 19:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@weltenwort
Copy link
Member Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #68 / discover Discover Saved Queries Manage saved queries updates a saved query

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

@weltenwort weltenwort merged commit 5f6dfb6 into elastic:main Dec 13, 2023
40 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyghiani tonyghiani tonyghiani approved these changes

Assignees

@weltenwort weltenwort

Labels
backport:skip This commit does not require backporting Feature:LogsExplorer Logs Explorer feature release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
6 participants
@weltenwort @apmmachine @elasticmachine @kibana-ci @tonyghiani @kibanamachine