Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Pass user messages to the config panel #172791

Merged
merged 2 commits into from
Dec 7, 2023
Merged

[Lens] Pass user messages to the config panel #172791

merged 2 commits into from
Dec 7, 2023

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Dec 7, 2023 •
edited by kibanamachine
Loading

Summary

Fixes #169175

@mbondyra mbondyra requested a review from a team as a code owner December 7, 2023 09:37
@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.12.0 labels Dec 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

stratoula
stratoula approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm 🎉

@stratoula stratoula added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Dec 7, 2023
@mbondyra mbondyra enabled auto-merge (squash) December 7, 2023 10:21
@mbondyra mbondyra disabled auto-merge December 7, 2023 11:14
@mbondyra mbondyra enabled auto-merge (squash) December 7, 2023 12:14
@mbondyra mbondyra merged commit 8f7a12c into elastic:main Dec 7, 2023
36 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB +271.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine mentioned this pull request Dec 7, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 7, 2023
@mbondyra
[Lens] Pass user messages to the config panel (elastic#172791)
31e9b42 
## Summary

Fixes elastic#169175

(cherry picked from commit 8f7a12c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@mbondyra mbondyra deleted the lens/pass_errors_to_panel branch December 7, 2023 13:39
kibanamachine added a commit that referenced this pull request Dec 7, 2023
@kibanamachine @mbondyra
[8.12] [Lens] Pass user messages to the config panel (#172791) (#172811)
7837193 
# Backport

This will backport the following commits from `main` to `8.12`:
- [[Lens] Pass user messages to the config panel
(#172791)](#172791)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-07T13:10:27Z","message":"[Lens]
Pass user messages to the config panel (#172791)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/169175","sha":"8f7a12cc42b4c0d2e14fc8084e2ab0c479d0aa9f","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","backport:prev-minor","v8.12.0","v8.13.0"],"number":172791,"url":"https://github.com/elastic/kibana/pull/172791","mergeCommit":{"message":"[Lens]
Pass user messages to the config panel (#172791)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/169175","sha":"8f7a12cc42b4c0d2e14fc8084e2ab0c479d0aa9f"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172791","number":172791,"mergeCommit":{"message":"[Lens]
Pass user messages to the config panel (#172791)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/169175","sha":"8f7a12cc42b4c0d2e14fc8084e2ab0c479d0aa9f"}}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <[email protected]>
This was referenced Dec 18, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.12.0 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit visualization panel on dashboard is not displaying the error for the missing field
5 participants
@mbondyra @elasticmachine @kibana-ci @kibanamachine @stratoula