Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Reverts getUserMessages function in inline editing flyout #173506

Closed
wants to merge 1 commit into from

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Dec 18, 2023

Summary

Reverts #172791

This is causing the getUserMessages to run for every suggested visualization but their state is not the same. For example heatmap doesnt expect layers but partition does. This is causing the getUserMessages to fail because if I select a heatmap suggestion (no layers) the getUserMessages for partition will run (without layers, while this is required) and the inline flyout will fail

@stratoula
Copy link
Contributor Author

/ci

@stratoula stratoula changed the title [ES|QL] Revert getUserMessages [ES|QL] Reverts getUserMessages function in inline editing flyout Dec 18, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB -271.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added v8.12.0 v8.13.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Lens labels Dec 18, 2023
@stratoula stratoula closed this Dec 18, 2023
@stratoula stratoula deleted the fix-inline-getusermessages branch December 22, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Lens v8.12.0 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants