[Lens] Fix context formula functions #172710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
drewdaemon
added
release_note:fix
Team:Visualizations
|
/ci |
|
/ci |
…ula-context-functions
|
/ci |
|
/ci |
…wdaemon/kibana into 170762/fix-formula-context-functions
|
/ci |
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
drewdaemon
commented
Dec 8, 2023
| @@ -86,7 +86,7 @@ pageLoadAssetSize: | |||
| kibanaUsageCollection: 16463 | |||
| kibanaUtils: 79713 | |||
| kubernetesSecurity: 77234 | |||
| lens: 39000 | |||
| lens: 41000 | |||
There was a problem hiding this comment.
Required a limit bump because of the new expression functions which are imported sync.
There was a problem hiding this comment.
Only went up about 1KB, so we don't have to be this generous....
botelastic
bot
added
the
Feature:ExpressionLanguage
drewdaemon
added
backport:prev-minor
jbudz
approved these changes
Dec 8, 2023
davismcphee
approved these changes
Dec 9, 2023
|
@dej611 can you take this review? You know this code better than me! |
drewdaemon
added a commit
that referenced
this pull request
Dec 11, 2023
## Summary While working on #172710 I noticed how loose our search context types were. This leeway seems like overkill given how we actually use the expressions framework. --------- Co-authored-by: kibanamachine <[email protected]>
…ula-context-functions
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
dej611
approved these changes
Dec 19, 2023
|
|
||
| const getTimeRangeAsNumber = (timeRange: TimeRange | undefined, now: number | undefined) => { | ||
| if (!timeRange) return 0; | ||
| const absoluteTimeRange = getAbsoluteTimeRange(timeRange, now ? { forceNow: new Date(now) } : {}); |
There was a problem hiding this comment.
Suggested change
| const absoluteTimeRange = getAbsoluteTimeRange(timeRange, now ? { forceNow: new Date(now) } : {}); | |
| const absoluteTimeRange = getAbsoluteTimeRange(timeRange, now != null ? { forceNow: new Date(now) } : {}); |
drewdaemon
force-pushed
the
170762/fix-formula-context-functions
branch
from
3503866 to
eea236f
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
drewdaemon
added a commit
to drewdaemon/kibana
that referenced
this pull request
Dec 19, 2023
## Summary While working on elastic#172710 I noticed how loose our search context types were. This leeway seems like overkill given how we actually use the expressions framework. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 570937f)
drewdaemon
added a commit
that referenced
this pull request
Dec 20, 2023
# Backport This will backport the following commits from `main` to `8.12`: - [[Lens] unify expression search context type (#172738)](#172738) This is a prerequisite to backporting #172710 <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-11T14:08:00Z","message":"[Lens] unify expression search context type (#172738)\n\n## Summary\r\n\r\nWhile working on #172710 I noticed\r\nhow loose our search context types were. This leeway seems like overkill\r\ngiven how we actually use the expressions framework.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"570937ff19c500d0d54b605b0602b6ffb2a6fb10","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:ExpressionLanguage","Team:Visualizations","release_note:skip","backport:skip","v8.13.0"],"number":172738,"url":"https://github.com/elastic/kibana/pull/172738","mergeCommit":{"message":"[Lens] unify expression search context type (#172738)\n\n## Summary\r\n\r\nWhile working on #172710 I noticed\r\nhow loose our search context types were. This leeway seems like overkill\r\ngiven how we actually use the expressions framework.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"570937ff19c500d0d54b605b0602b6ffb2a6fb10"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172738","number":172738,"mergeCommit":{"message":"[Lens] unify expression search context type (#172738)\n\n## Summary\r\n\r\nWhile working on #172710 I noticed\r\nhow loose our search context types were. This leeway seems like overkill\r\ngiven how we actually use the expressions framework.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"570937ff19c500d0d54b605b0602b6ffb2a6fb10"}}]}] BACKPORT--> Co-authored-by: Kibana Machine <[email protected]>
drewdaemon
added a commit
to drewdaemon/kibana
that referenced
this pull request
Dec 20, 2023
## Summary Fix elastic#170762 https://github.com/elastic/kibana/assets/315764/f5b50ffa-4a03-45ee-bc7a-2f2aca7fa3bd ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 99763dc)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
drewdaemon
added a commit
that referenced
this pull request
Dec 20, 2023
# Backport This will backport the following commits from `main` to `8.12`: - [[Lens] Fix context formula functions (#172710)](#172710) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-19T15:32:31Z","message":"[Lens] Fix context formula functions (#172710)\n\n## Summary\r\nFix https://github.com/elastic/kibana/issues/170762\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/315764/f5b50ffa-4a03-45ee-bc7a-2f2aca7fa3bd\r\n\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"99763dc61647c817384019f6603de7ad258eea01","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ExpressionLanguage","Team:Visualizations","Feature:Lens","backport:prev-minor","v8.13.0"],"number":172710,"url":"https://github.com/elastic/kibana/pull/172710","mergeCommit":{"message":"[Lens] Fix context formula functions (#172710)\n\n## Summary\r\nFix https://github.com/elastic/kibana/issues/170762\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/315764/f5b50ffa-4a03-45ee-bc7a-2f2aca7fa3bd\r\n\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"99763dc61647c817384019f6603de7ad258eea01"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172710","number":172710,"mergeCommit":{"message":"[Lens] Fix context formula functions (#172710)\n\n## Summary\r\nFix https://github.com/elastic/kibana/issues/170762\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/315764/f5b50ffa-4a03-45ee-bc7a-2f2aca7fa3bd\r\n\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"99763dc61647c817384019f6603de7ad258eea01"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #170762
Screen.Recording.2023-12-07.at.4.38.49.PM.mov
Checklist