[Lens] unify expression search context type #172738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
added
the
Team:Visualizations
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
ThomThomson
approved these changes
Dec 7, 2023
botelastic
bot
added
the
Feature:ExpressionLanguage
drewdaemon
added
the
release_note:skip
stratoula
approved these changes
Dec 8, 2023
davismcphee
approved these changes
Dec 9, 2023
kibanamachine
added
v8.13.0
backport:skip
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
drewdaemon
added a commit
to drewdaemon/kibana
that referenced
this pull request
Dec 19, 2023
## Summary While working on elastic#172710 I noticed how loose our search context types were. This leeway seems like overkill given how we actually use the expressions framework. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 570937f)
drewdaemon
added a commit
that referenced
this pull request
Dec 20, 2023
# Backport This will backport the following commits from `main` to `8.12`: - [[Lens] unify expression search context type (#172738)](#172738) This is a prerequisite to backporting #172710 <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-11T14:08:00Z","message":"[Lens] unify expression search context type (#172738)\n\n## Summary\r\n\r\nWhile working on #172710 I noticed\r\nhow loose our search context types were. This leeway seems like overkill\r\ngiven how we actually use the expressions framework.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"570937ff19c500d0d54b605b0602b6ffb2a6fb10","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:ExpressionLanguage","Team:Visualizations","release_note:skip","backport:skip","v8.13.0"],"number":172738,"url":"https://github.com/elastic/kibana/pull/172738","mergeCommit":{"message":"[Lens] unify expression search context type (#172738)\n\n## Summary\r\n\r\nWhile working on #172710 I noticed\r\nhow loose our search context types were. This leeway seems like overkill\r\ngiven how we actually use the expressions framework.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"570937ff19c500d0d54b605b0602b6ffb2a6fb10"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172738","number":172738,"mergeCommit":{"message":"[Lens] unify expression search context type (#172738)\n\n## Summary\r\n\r\nWhile working on #172710 I noticed\r\nhow loose our search context types were. This leeway seems like overkill\r\ngiven how we actually use the expressions framework.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"570937ff19c500d0d54b605b0602b6ffb2a6fb10"}}]}] BACKPORT--> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on #172710 I noticed how loose our search context types were. This leeway seems like overkill given how we actually use the expressions framework.