[EBT] fix browser-side elasticsearch context schema #172676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Team:Core
jloleysens
approved these changes
Dec 6, 2023
💚 Build Succeeded
Metrics [docs]Page load bundle
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-core (Team:Core) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 7, 2023
## Summary The `cluster_build_flavor` was propagated to the browser-side and then used in the context, but without being explicitly defined in the schema. this PR fixes it by properly adding the field. (cherry picked from commit 754c298)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 7, 2023
…172787) # Backport This will backport the following commits from `main` to `8.12`: - [[EBT] fix browser-side elasticsearch context schema (#172676)](#172676) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pierre Gayvallet","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-07T09:08:45Z","message":"[EBT] fix browser-side elasticsearch context schema (#172676)\n\n## Summary\r\n\r\nThe `cluster_build_flavor` was propagated to the browser-side and then\r\nused in the context, but without being explicitly defined in the schema.\r\n\r\nthis PR fixes it by properly adding the field.","sha":"754c298d12f9c51334a35d0c8b0681da0126276e","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Feature:Telemetry","release_note:skip","v8.12.0","v8.13.0"],"number":172676,"url":"https://github.com/elastic/kibana/pull/172676","mergeCommit":{"message":"[EBT] fix browser-side elasticsearch context schema (#172676)\n\n## Summary\r\n\r\nThe `cluster_build_flavor` was propagated to the browser-side and then\r\nused in the context, but without being explicitly defined in the schema.\r\n\r\nthis PR fixes it by properly adding the field.","sha":"754c298d12f9c51334a35d0c8b0681da0126276e"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172676","number":172676,"mergeCommit":{"message":"[EBT] fix browser-side elasticsearch context schema (#172676)\n\n## Summary\r\n\r\nThe `cluster_build_flavor` was propagated to the browser-side and then\r\nused in the context, but without being explicitly defined in the schema.\r\n\r\nthis PR fixes it by properly adding the field.","sha":"754c298d12f9c51334a35d0c8b0681da0126276e"}}]}] BACKPORT--> Co-authored-by: Pierre Gayvallet <[email protected]>
|
Related to #171112, which fixes it on the server-side. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
cluster_build_flavorwas propagated to the browser-side and then used in the context, but without being explicitly defined in the schema.this PR fixes it by properly adding the field.