Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES] cluster_build_flavor may be undefined #171112

Merged
merged 3 commits into from
Nov 14, 2023
Merged

[ES] cluster_build_flavor may be undefined #171112

merged 3 commits into from
Nov 14, 2023

Conversation

afharo
Copy link
Member

@afharo afharo commented Nov 13, 2023 •
edited
Loading

Summary

We noticed that cluster_build_flavor may be undefined in some situations.

Let's reflect that in the types and EBT schema.

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Nov 13, 2023
@afharo afharo self-assigned this Nov 13, 2023
@afharo afharo requested a review from a team as a code owner November 13, 2023 16:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

gsoldevila
gsoldevila approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green!

@afharo afharo enabled auto-merge (squash) November 13, 2023 16:42
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Security Cypress Tests #3 / Detections > Callouts indicating read-only access to resources On Detections home page When a user clicks Dismiss on the callout We hide it and persist the dismissal We hide it and persist the dismissal

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

@afharo afharo merged commit da3833e into elastic:main Nov 14, 2023
@afharo afharo deleted the ebt/remove-confusing-error branch November 14, 2023 10:02
@logeekal logeekal mentioned this pull request Nov 16, 2023
Closed
@gsoldevila gsoldevila mentioned this pull request Dec 11, 2023
Merged
@gsoldevila
Copy link
Contributor

Related to #172676, which fixes it on browser-side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsoldevila gsoldevila gsoldevila approved these changes

Assignees

@afharo afharo

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afharo @elasticmachine @kibana-ci @gsoldevila @kibanamachine