Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connectors][ServiceNow ITSM] Edit labels, automate screenshots, add cross-scope privileges #172533

Merged
merged 6 commits into from
Dec 13, 2023
Merged

[Connectors][ServiceNow ITSM] Edit labels, automate screenshots, add cross-scope privileges #172533

merged 6 commits into from
Dec 13, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 5, 2023

Summary

Relates #170164

This PR:

  • Updates the ServiceNow ITSM connector UI so that the "required" and "optional" qualifiers are subdued and separated from the field labels.
  • Automates two of the screenshots that are used in https://www.elastic.co/guide/en/kibana/master/servicenow-action-type.html
  • Adds details about the necessary cross-scope privileges required for the Elastic for ITSM app.
  • Sorts the list of configuration options alphabetically in the ServiceNow ITSM connector documentation.
  • Moves the ServiceNow configuration steps to the end of the page, same as in other connector pages.

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework v8.12.1 labels Dec 5, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review December 5, 2023 16:56
@lcawl lcawl requested a review from a team as a code owner December 5, 2023 16:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

cnasikas
cnasikas reviewed Dec 6, 2023
View reviewed changes
docs/management/connectors/action-types/servicenow.asciidoc Outdated
[[servicenow-itsm-connector-privileges]]
==== Assign cross-scope privileges

The Elastic for ITSM app requires specific cross-scope privilege records to run successfully:
Copy link
Member

@cnasikas cnasikas Dec 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to do the same for SecOps on a different PR?

Screenshot 2023-12-06 at 11 07 57 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 548.0KB 548.0KB +48.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 103ca85 into elastic:main Dec 13, 2023
36 checks passed
@lcawl lcawl deleted the itsm-connector branch December 13, 2023 18:43
@lcawl lcawl mentioned this pull request Dec 13, 2023
Closed
@kibanamachine kibanamachine mentioned this pull request Jan 9, 2024
Merged
lcawl added a commit to lcawl/kibana that referenced this pull request Jan 10, 2024
@lcawl
[Connectors][ServiceNow ITSM] Edit labels, automate screenshots, add …
8d658ba 
…cross-scope privileges (elastic#172533)

(cherry picked from commit 103ca85)
@lcawl lcawl mentioned this pull request Jan 10, 2024
Merged
@lcawl
Copy link
Contributor Author

lcawl commented Jan 10, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Jan 11, 2024
@lcawl
[8.12] [Connectors][ServiceNow ITSM, SecOps] Automate screenshots, ad…
9554793 
…d cross-scope privileges (#172533, #173941) (#174560)
@mistic mistic removed the v8.12.0 label Jan 17, 2024
@mistic
Copy link
Member

mistic commented Jan 17, 2024

This PR didn't make it into the latest BC for 8.12.0. Updating the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.1 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lcawl @apmmachine @elasticmachine @kibana-ci @mistic @cnasikas @kibanamachine