Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connectors][ServiceNow SecOps] Automate screenshots, add cross-scope privileges #173941

Merged
merged 8 commits into from
Jan 9, 2024
Merged

[Connectors][ServiceNow SecOps] Automate screenshots, add cross-scope privileges #173941

merged 8 commits into from
Jan 9, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 22, 2023 •
edited by kibanamachine
Loading

Summary

Fixes #170165

This PR:

  • Automates two of the screenshots that are used in https://www.elastic.co/guide/en/kibana/master/servicenow-sir-action-type.html
  • Adds details about the necessary cross-scope privileges required for the Elastic for SecOps app.
  • Sorts the list of configuration options alphabetically in the ServiceNow SecOps connector documentation.
  • Moves the ServiceNow configuration steps to the end of the page, same as in other connector pages.
  • Synchs some changes (e.g. table layout) in the ServiceNow ITSM page so that they align.

Preview

https://kibana_173941.docs-preview.app.elstc.co/guide/en/kibana/master/servicenow-sir-action-type.html

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review December 22, 2023 22:38
@lcawl lcawl requested a review from a team as a code owner December 22, 2023 22:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl enabled auto-merge (squash) January 8, 2024 14:50
@lcawl lcawl merged commit 2614e92 into elastic:main Jan 9, 2024
19 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.12 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.12:
- [Connectors][IBM Resilient] Edit required labels and automate screenshots (#166022)
- [Connectors][ServiceNow ITSM] Edit labels, automate screenshots, add cross-scope privileges (#172533)

Manual backport

To create the backport manually run:

node scripts/backport --pr 173941

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl deleted the servicenow-sir branch January 9, 2024 23:51
lcawl added a commit to lcawl/kibana that referenced this pull request Jan 10, 2024
@lcawl
[Connectors][ServiceNow SecOps] Automate screenshots, add cross-scope…
0bc0ed4 
… privileges (elastic#173941)
@lcawl lcawl mentioned this pull request Jan 10, 2024
Merged
nreese pushed a commit to nreese/kibana that referenced this pull request Jan 10, 2024
@lcawl @nreese
[Connectors][ServiceNow SecOps] Automate screenshots, add cross-scope…
9a34454 
… privileges (elastic#173941)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 10, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
@lcawl @delanni
[Connectors][ServiceNow SecOps] Automate screenshots, add cross-scope…
73c762c 
… privileges (elastic#173941)
lcawl added a commit that referenced this pull request Jan 11, 2024
@lcawl
[8.12] [Connectors][ServiceNow ITSM, SecOps] Automate screenshots, ad…
9554793 
…d cross-scope privileges (#172533, #173941) (#174560)
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Response Ops] Scope Privilege for ServiceNow SIR
6 participants
@lcawl @apmmachine @elasticmachine @kibana-ci @kibanamachine @cnasikas