Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security Posture][Benchmark Improvements] Rules Page Improvements phase 1 #172424

Draft
wants to merge 57 commits into
base: main
Choose a base branch
from

Conversation

animehart
Copy link
Contributor

Summary

This PR updates the Rules Page looks to accomodate the changes we made to Benchmark page
This PR also adds Empty page (when user doesn't have any CSP integration) for Benchmark page

NOTE:
Either Merge the Benchmark Improvements PR First then this
OR
Merge this for both Benchmark and Rules page improvements

Summarize your PR. If it involves visual changes include a screenshot or gif.
Screenshot 2023-12-01 at 1 07 39 AM
Screenshot 2023-12-02 at 8 36 40 AM

animehart and others added 30 commits June 22, 2023 11:17
@kibana-ci
Copy link
Collaborator

kibana-ci commented Dec 5, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 429 427 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 443.7KB 444.7KB +1022.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudSecurityPosture 15.8KB 15.7KB -44.0B
Unknown metric groups

ESLint disabled in files

id before after diff
cloudSecurityPosture 1 0 -1

Total ESLint disabled count

id before after diff
cloudSecurityPosture 25 24 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants