Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11] fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts (#172395) #172403

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

kibanamachine
Copy link
Contributor

…/test/saved_object_tagging/functional/tests/dashboard_integration·ts (elastic#172395)

Fixes elastic#160583

Test failed because combobox trying to select already selected tag. PR
fixes test by using combobox service to set element. Combobox service
includes logic to only select value when not selected.

![image](https://github.com/elastic/kibana/assets/373691/e4d04854-b147-4d88-a7e5-5a7bc5fa3f38)

```
[00:07:27]           │ debg Find.clickByCssSelector('[data-test-subj="savedObjectTagSelector"]') with timeout=10000
[00:07:27]           │ debg Find.findByCssSelector('[data-test-subj="savedObjectTagSelector"]') with timeout=10000
[00:07:27]           │ debg TestSubjects.click(tagSelectorOption-tag-1)
[00:07:27]           │ debg Find.clickByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000
[00:07:27]           │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000
[00:07:37]           │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:07:37]           │      Wait timed out after 10003ms
[00:07:38]           │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000
[00:07:48]           │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:07:48]           │      Wait timed out after 10038ms
[00:07:48]           │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000
[00:07:58]           │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:07:58]           │      Wait timed out after 10054ms
[00:07:59]           │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000
[00:08:09]           │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:08:09]           │      Wait timed out after 10013ms
[00:08:09]           │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000
[00:08:19]           │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:08:19]           │      Wait timed out after 10038ms
[00:08:20]           │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000
[00:08:30]           │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:08:30]           │      Wait timed out after 10005ms
[00:08:30]           │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000
[00:08:40]           │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:08:40]           │      Wait timed out after 10034ms
[00:08:41]           │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000
[00:08:51]           │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:08:51]           │      Wait timed out after 10037ms
[00:08:51]           │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000
[00:09:01]           │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:09:01]           │      Wait timed out after 10007ms
[00:09:02]           │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000
[00:09:12]           │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:09:12]           │      Wait timed out after 10054ms
[00:09:13]           │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000
[00:09:23]           │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:09:23]           │      Wait timed out after 10037ms
[00:09:23]           │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000
[00:09:33]           │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:09:33]           │      Wait timed out after 10042ms
[00:09:34]           │ debg --- retry.try error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:09:34]           │      Wait timed out after 10042ms
[00:09:34]           │          at /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17
[00:09:34]           │          at processTicksAndRejections (node:internal/process/task_queues:95:5)
[00:09:34]           │ info Taking window screenshot "/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/screenshots/failure/saved objects tagging - functional tests dashboard integration creating allows t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.png"
[00:09:34]           │ info Current URL is: http://localhost:5620/app/dashboards#/create?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))
[00:09:34]           │ info Saving page source to: /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/failure_debug/html/saved objects tagging - functional tests dashboard integration creating allows t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.html
[00:09:34]           └- ✖ fail: saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard
[00:09:34]           │      Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"])
[00:09:34]           │ Wait timed out after 10042ms
[00:09:34]           │     at /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17
[00:09:34]           │     at processTicksAndRejections (node:internal/process/task_queues:95:5)
[00:09:34]           │     at onFailure (retry_for_success.ts:17:9)
[00:09:34]           │     at retryForSuccess (retry_for_success.ts:59:13)
[00:09:34]           │     at RetryService.try (retry.ts:31:12)
[00:09:34]           │     at Proxy.clickByCssSelector (find.ts:417:5)
[00:09:34]           │     at TestSubjects.click (test_subjects.ts:164:5)
[00:09:34]           │     at DashboardPageObject.selectDashboardTags (dashboard_page.ts:560:7)
[00:09:34]           │     at DashboardPageObject.enterDashboardTitleAndClickSave (dashboard_page.ts:544:7)
[00:09:34]           │     at dashboard_page.ts:481:7
[00:09:34]           │     at runAttempt (retry_for_success.ts:29:15)
[00:09:34]           │     at retryForSuccess (retry_for_success.ts:68:21)
[00:09:34]           │     at RetryService.try (retry.ts:31:12)
[00:09:34]           │     at DashboardPageObject.saveDashboard (dashboard_page.ts:480:5)
[00:09:34]           │     at Context.<anonymous> (dashboard_integration.ts:87:9)
[00:09:34]           │     at Object.apply (wrap_function.js:73:16)
[00:09:34]           │       at onFailure (retry_for_success.ts:17:9)
[00:09:34]           │       at retryForSuccess (retry_for_success.ts:59:13)
[00:09:34]           │       at RetryService.try (retry.ts:31:12)
[00:09:34]           │       at DashboardPageObject.saveDashboard (dashboard_page.ts:480:5)
[00:09:34]           │       at Context.<anonymous> (dashboard_integration.ts:87:9)
[00:09:34]           │       at Object.apply (wrap_function.js:73:16)
[00:09:34]           │
[00:09:34]           │
```

(cherry picked from commit d3a8699)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nreese

@kibanamachine kibanamachine merged commit be9d200 into elastic:8.11 Dec 1, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants