-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts #172395
Conversation
…/test/saved_object_tagging/functional/tests/dashboard_integration·ts
Pinging @elastic/kibana-presentation (Team:Presentation) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 Makes sense to me.
…/test/saved_object_tagging/functional/tests/dashboard_integration·ts (elastic#172395) Fixes elastic#160583 Test failed because combobox trying to select already selected tag. PR fixes test by using combobox service to set element. Combobox service includes logic to only select value when not selected. ![image](https://github.com/elastic/kibana/assets/373691/e4d04854-b147-4d88-a7e5-5a7bc5fa3f38) ``` [00:07:27] │ debg Find.clickByCssSelector('[data-test-subj="savedObjectTagSelector"]') with timeout=10000 [00:07:27] │ debg Find.findByCssSelector('[data-test-subj="savedObjectTagSelector"]') with timeout=10000 [00:07:27] │ debg TestSubjects.click(tagSelectorOption-tag-1) [00:07:27] │ debg Find.clickByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000 [00:07:27] │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000 [00:07:37] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:07:37] │ Wait timed out after 10003ms [00:07:38] │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000 [00:07:48] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:07:48] │ Wait timed out after 10038ms [00:07:48] │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000 [00:07:58] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:07:58] │ Wait timed out after 10054ms [00:07:59] │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000 [00:08:09] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:08:09] │ Wait timed out after 10013ms [00:08:09] │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000 [00:08:19] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:08:19] │ Wait timed out after 10038ms [00:08:20] │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000 [00:08:30] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:08:30] │ Wait timed out after 10005ms [00:08:30] │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000 [00:08:40] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:08:40] │ Wait timed out after 10034ms [00:08:41] │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000 [00:08:51] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:08:51] │ Wait timed out after 10037ms [00:08:51] │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000 [00:09:01] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:09:01] │ Wait timed out after 10007ms [00:09:02] │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000 [00:09:12] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:09:12] │ Wait timed out after 10054ms [00:09:13] │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000 [00:09:23] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:09:23] │ Wait timed out after 10037ms [00:09:23] │ debg Find.findByCssSelector('[data-test-subj="tagSelectorOption-tag-1"]') with timeout=10000 [00:09:33] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:09:33] │ Wait timed out after 10042ms [00:09:34] │ debg --- retry.try error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:09:34] │ Wait timed out after 10042ms [00:09:34] │ at /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17 [00:09:34] │ at processTicksAndRejections (node:internal/process/task_queues:95:5) [00:09:34] │ info Taking window screenshot "/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/screenshots/failure/saved objects tagging - functional tests dashboard integration creating allows t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.png" [00:09:34] │ info Current URL is: http://localhost:5620/app/dashboards#/create?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now)) [00:09:34] │ info Saving page source to: /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/failure_debug/html/saved objects tagging - functional tests dashboard integration creating allows t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.html [00:09:34] â””- ✖ fail: saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard [00:09:34] │ Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="tagSelectorOption-tag-1"]) [00:09:34] │ Wait timed out after 10042ms [00:09:34] │ at /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17 [00:09:34] │ at processTicksAndRejections (node:internal/process/task_queues:95:5) [00:09:34] │ at onFailure (retry_for_success.ts:17:9) [00:09:34] │ at retryForSuccess (retry_for_success.ts:59:13) [00:09:34] │ at RetryService.try (retry.ts:31:12) [00:09:34] │ at Proxy.clickByCssSelector (find.ts:417:5) [00:09:34] │ at TestSubjects.click (test_subjects.ts:164:5) [00:09:34] │ at DashboardPageObject.selectDashboardTags (dashboard_page.ts:560:7) [00:09:34] │ at DashboardPageObject.enterDashboardTitleAndClickSave (dashboard_page.ts:544:7) [00:09:34] │ at dashboard_page.ts:481:7 [00:09:34] │ at runAttempt (retry_for_success.ts:29:15) [00:09:34] │ at retryForSuccess (retry_for_success.ts:68:21) [00:09:34] │ at RetryService.try (retry.ts:31:12) [00:09:34] │ at DashboardPageObject.saveDashboard (dashboard_page.ts:480:5) [00:09:34] │ at Context.<anonymous> (dashboard_integration.ts:87:9) [00:09:34] │ at Object.apply (wrap_function.js:73:16) [00:09:34] │ at onFailure (retry_for_success.ts:17:9) [00:09:34] │ at retryForSuccess (retry_for_success.ts:59:13) [00:09:34] │ at RetryService.try (retry.ts:31:12) [00:09:34] │ at DashboardPageObject.saveDashboard (dashboard_page.ts:480:5) [00:09:34] │ at Context.<anonymous> (dashboard_integration.ts:87:9) [00:09:34] │ at Object.apply (wrap_function.js:73:16) [00:09:34] │ [00:09:34] │ ``` (cherry picked from commit d3a8699)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
….x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts (#172395) (#172403) # Backport This will backport the following commits from `main` to `8.11`: - [fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts (#172395)](#172395) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-01T22:12:57Z","message":"fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts (#172395)\n\nFixes https://github.com/elastic/kibana/issues/160583\r\n\r\nTest failed because combobox trying to select already selected tag. PR\r\nfixes test by using combobox service to set element. Combobox service\r\nincludes logic to only select value when not selected.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/373691/e4d04854-b147-4d88-a7e5-5a7bc5fa3f38)\r\n\r\n```\r\n[00:07:27] │ debg Find.clickByCssSelector('[data-test-subj=\"savedObjectTagSelector\"]') with timeout=10000\r\n[00:07:27] │ debg Find.findByCssSelector('[data-test-subj=\"savedObjectTagSelector\"]') with timeout=10000\r\n[00:07:27] │ debg TestSubjects.click(tagSelectorOption-tag-1)\r\n[00:07:27] │ debg Find.clickByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:07:27] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:07:37] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:37] │ Wait timed out after 10003ms\r\n[00:07:38] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:07:48] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:48] │ Wait timed out after 10038ms\r\n[00:07:48] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:07:58] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:58] │ Wait timed out after 10054ms\r\n[00:07:59] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:09] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:09] │ Wait timed out after 10013ms\r\n[00:08:09] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:19] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:19] │ Wait timed out after 10038ms\r\n[00:08:20] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:30] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:30] │ Wait timed out after 10005ms\r\n[00:08:30] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:40] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:40] │ Wait timed out after 10034ms\r\n[00:08:41] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:51] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:51] │ Wait timed out after 10037ms\r\n[00:08:51] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:09:01] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:01] │ Wait timed out after 10007ms\r\n[00:09:02] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:09:12] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:12] │ Wait timed out after 10054ms\r\n[00:09:13] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:09:23] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:23] │ Wait timed out after 10037ms\r\n[00:09:23] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:09:33] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:33] │ Wait timed out after 10042ms\r\n[00:09:34] │ debg --- retry.try error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:34] │ Wait timed out after 10042ms\r\n[00:09:34] │ at /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17\r\n[00:09:34] │ at processTicksAndRejections (node:internal/process/task_queues:95:5)\r\n[00:09:34] │ info Taking window screenshot \"/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/screenshots/failure/saved objects tagging - functional tests dashboard integration creating allows t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.png\"\r\n[00:09:34] │ info Current URL is: http://localhost:5620/app/dashboards#/create?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))\r\n[00:09:34] │ info Saving page source to: /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/failure_debug/html/saved objects tagging - functional tests dashboard integration creating allows t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.html\r\n[00:09:34] â””- ✖ fail: saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard\r\n[00:09:34] │ Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:34] │ Wait timed out after 10042ms\r\n[00:09:34] │ at /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17\r\n[00:09:34] │ at processTicksAndRejections (node:internal/process/task_queues:95:5)\r\n[00:09:34] │ at onFailure (retry_for_success.ts:17:9)\r\n[00:09:34] │ at retryForSuccess (retry_for_success.ts:59:13)\r\n[00:09:34] │ at RetryService.try (retry.ts:31:12)\r\n[00:09:34] │ at Proxy.clickByCssSelector (find.ts:417:5)\r\n[00:09:34] │ at TestSubjects.click (test_subjects.ts:164:5)\r\n[00:09:34] │ at DashboardPageObject.selectDashboardTags (dashboard_page.ts:560:7)\r\n[00:09:34] │ at DashboardPageObject.enterDashboardTitleAndClickSave (dashboard_page.ts:544:7)\r\n[00:09:34] │ at dashboard_page.ts:481:7\r\n[00:09:34] │ at runAttempt (retry_for_success.ts:29:15)\r\n[00:09:34] │ at retryForSuccess (retry_for_success.ts:68:21)\r\n[00:09:34] │ at RetryService.try (retry.ts:31:12)\r\n[00:09:34] │ at DashboardPageObject.saveDashboard (dashboard_page.ts:480:5)\r\n[00:09:34] │ at Context.<anonymous> (dashboard_integration.ts:87:9)\r\n[00:09:34] │ at Object.apply (wrap_function.js:73:16)\r\n[00:09:34] │ at onFailure (retry_for_success.ts:17:9)\r\n[00:09:34] │ at retryForSuccess (retry_for_success.ts:59:13)\r\n[00:09:34] │ at RetryService.try (retry.ts:31:12)\r\n[00:09:34] │ at DashboardPageObject.saveDashboard (dashboard_page.ts:480:5)\r\n[00:09:34] │ at Context.<anonymous> (dashboard_integration.ts:87:9)\r\n[00:09:34] │ at Object.apply (wrap_function.js:73:16)\r\n[00:09:34] │ \r\n[00:09:34] │ \r\n```","sha":"d3a8699f65d426e738ac742d842226867fe65c8c","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v8.11.0","v8.12.0"],"number":172395,"url":"https://github.com/elastic/kibana/pull/172395","mergeCommit":{"message":"fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts (#172395)\n\nFixes https://github.com/elastic/kibana/issues/160583\r\n\r\nTest failed because combobox trying to select already selected tag. PR\r\nfixes test by using combobox service to set element. Combobox service\r\nincludes logic to only select value when not selected.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/373691/e4d04854-b147-4d88-a7e5-5a7bc5fa3f38)\r\n\r\n```\r\n[00:07:27] │ debg Find.clickByCssSelector('[data-test-subj=\"savedObjectTagSelector\"]') with timeout=10000\r\n[00:07:27] │ debg Find.findByCssSelector('[data-test-subj=\"savedObjectTagSelector\"]') with timeout=10000\r\n[00:07:27] │ debg TestSubjects.click(tagSelectorOption-tag-1)\r\n[00:07:27] │ debg Find.clickByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:07:27] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:07:37] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:37] │ Wait timed out after 10003ms\r\n[00:07:38] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:07:48] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:48] │ Wait timed out after 10038ms\r\n[00:07:48] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:07:58] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:58] │ Wait timed out after 10054ms\r\n[00:07:59] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:09] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:09] │ Wait timed out after 10013ms\r\n[00:08:09] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:19] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:19] │ Wait timed out after 10038ms\r\n[00:08:20] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:30] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:30] │ Wait timed out after 10005ms\r\n[00:08:30] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:40] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:40] │ Wait timed out after 10034ms\r\n[00:08:41] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:51] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:51] │ Wait timed out after 10037ms\r\n[00:08:51] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:09:01] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:01] │ Wait timed out after 10007ms\r\n[00:09:02] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:09:12] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:12] │ Wait timed out after 10054ms\r\n[00:09:13] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:09:23] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:23] │ Wait timed out after 10037ms\r\n[00:09:23] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:09:33] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:33] │ Wait timed out after 10042ms\r\n[00:09:34] │ debg --- retry.try error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:34] │ Wait timed out after 10042ms\r\n[00:09:34] │ at /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17\r\n[00:09:34] │ at processTicksAndRejections (node:internal/process/task_queues:95:5)\r\n[00:09:34] │ info Taking window screenshot \"/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/screenshots/failure/saved objects tagging - functional tests dashboard integration creating allows t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.png\"\r\n[00:09:34] │ info Current URL is: http://localhost:5620/app/dashboards#/create?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))\r\n[00:09:34] │ info Saving page source to: /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/failure_debug/html/saved objects tagging - functional tests dashboard integration creating allows t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.html\r\n[00:09:34] â””- ✖ fail: saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard\r\n[00:09:34] │ Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:34] │ Wait timed out after 10042ms\r\n[00:09:34] │ at /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17\r\n[00:09:34] │ at processTicksAndRejections (node:internal/process/task_queues:95:5)\r\n[00:09:34] │ at onFailure (retry_for_success.ts:17:9)\r\n[00:09:34] │ at retryForSuccess (retry_for_success.ts:59:13)\r\n[00:09:34] │ at RetryService.try (retry.ts:31:12)\r\n[00:09:34] │ at Proxy.clickByCssSelector (find.ts:417:5)\r\n[00:09:34] │ at TestSubjects.click (test_subjects.ts:164:5)\r\n[00:09:34] │ at DashboardPageObject.selectDashboardTags (dashboard_page.ts:560:7)\r\n[00:09:34] │ at DashboardPageObject.enterDashboardTitleAndClickSave (dashboard_page.ts:544:7)\r\n[00:09:34] │ at dashboard_page.ts:481:7\r\n[00:09:34] │ at runAttempt (retry_for_success.ts:29:15)\r\n[00:09:34] │ at retryForSuccess (retry_for_success.ts:68:21)\r\n[00:09:34] │ at RetryService.try (retry.ts:31:12)\r\n[00:09:34] │ at DashboardPageObject.saveDashboard (dashboard_page.ts:480:5)\r\n[00:09:34] │ at Context.<anonymous> (dashboard_integration.ts:87:9)\r\n[00:09:34] │ at Object.apply (wrap_function.js:73:16)\r\n[00:09:34] │ at onFailure (retry_for_success.ts:17:9)\r\n[00:09:34] │ at retryForSuccess (retry_for_success.ts:59:13)\r\n[00:09:34] │ at RetryService.try (retry.ts:31:12)\r\n[00:09:34] │ at DashboardPageObject.saveDashboard (dashboard_page.ts:480:5)\r\n[00:09:34] │ at Context.<anonymous> (dashboard_integration.ts:87:9)\r\n[00:09:34] │ at Object.apply (wrap_function.js:73:16)\r\n[00:09:34] │ \r\n[00:09:34] │ \r\n```","sha":"d3a8699f65d426e738ac742d842226867fe65c8c"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172395","number":172395,"mergeCommit":{"message":"fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts (#172395)\n\nFixes https://github.com/elastic/kibana/issues/160583\r\n\r\nTest failed because combobox trying to select already selected tag. PR\r\nfixes test by using combobox service to set element. Combobox service\r\nincludes logic to only select value when not selected.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/373691/e4d04854-b147-4d88-a7e5-5a7bc5fa3f38)\r\n\r\n```\r\n[00:07:27] │ debg Find.clickByCssSelector('[data-test-subj=\"savedObjectTagSelector\"]') with timeout=10000\r\n[00:07:27] │ debg Find.findByCssSelector('[data-test-subj=\"savedObjectTagSelector\"]') with timeout=10000\r\n[00:07:27] │ debg TestSubjects.click(tagSelectorOption-tag-1)\r\n[00:07:27] │ debg Find.clickByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:07:27] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:07:37] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:37] │ Wait timed out after 10003ms\r\n[00:07:38] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:07:48] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:48] │ Wait timed out after 10038ms\r\n[00:07:48] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:07:58] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:07:58] │ Wait timed out after 10054ms\r\n[00:07:59] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:09] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:09] │ Wait timed out after 10013ms\r\n[00:08:09] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:19] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:19] │ Wait timed out after 10038ms\r\n[00:08:20] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:30] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:30] │ Wait timed out after 10005ms\r\n[00:08:30] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:40] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:40] │ Wait timed out after 10034ms\r\n[00:08:41] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:08:51] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:08:51] │ Wait timed out after 10037ms\r\n[00:08:51] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:09:01] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:01] │ Wait timed out after 10007ms\r\n[00:09:02] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:09:12] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:12] │ Wait timed out after 10054ms\r\n[00:09:13] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:09:23] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:23] │ Wait timed out after 10037ms\r\n[00:09:23] │ debg Find.findByCssSelector('[data-test-subj=\"tagSelectorOption-tag-1\"]') with timeout=10000\r\n[00:09:33] │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:33] │ Wait timed out after 10042ms\r\n[00:09:34] │ debg --- retry.try error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:34] │ Wait timed out after 10042ms\r\n[00:09:34] │ at /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17\r\n[00:09:34] │ at processTicksAndRejections (node:internal/process/task_queues:95:5)\r\n[00:09:34] │ info Taking window screenshot \"/var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/screenshots/failure/saved objects tagging - functional tests dashboard integration creating allows t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.png\"\r\n[00:09:34] │ info Current URL is: http://localhost:5620/app/dashboards#/create?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-15m,to:now))\r\n[00:09:34] │ info Saving page source to: /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/x-pack/test/saved_object_tagging/functional/failure_debug/html/saved objects tagging - functional tests dashboard integration creating allows t-29814279444f4d298f24b012c2e451886d9c481ab2ec65240025329c4f56ba13.html\r\n[00:09:34] â””- ✖ fail: saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard\r\n[00:09:34] │ Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj=\"tagSelectorOption-tag-1\"])\r\n[00:09:34] │ Wait timed out after 10042ms\r\n[00:09:34] │ at /var/lib/buildkite-agent/builds/kb-n2-4-spot-ee2d6153f1c6deeb/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17\r\n[00:09:34] │ at processTicksAndRejections (node:internal/process/task_queues:95:5)\r\n[00:09:34] │ at onFailure (retry_for_success.ts:17:9)\r\n[00:09:34] │ at retryForSuccess (retry_for_success.ts:59:13)\r\n[00:09:34] │ at RetryService.try (retry.ts:31:12)\r\n[00:09:34] │ at Proxy.clickByCssSelector (find.ts:417:5)\r\n[00:09:34] │ at TestSubjects.click (test_subjects.ts:164:5)\r\n[00:09:34] │ at DashboardPageObject.selectDashboardTags (dashboard_page.ts:560:7)\r\n[00:09:34] │ at DashboardPageObject.enterDashboardTitleAndClickSave (dashboard_page.ts:544:7)\r\n[00:09:34] │ at dashboard_page.ts:481:7\r\n[00:09:34] │ at runAttempt (retry_for_success.ts:29:15)\r\n[00:09:34] │ at retryForSuccess (retry_for_success.ts:68:21)\r\n[00:09:34] │ at RetryService.try (retry.ts:31:12)\r\n[00:09:34] │ at DashboardPageObject.saveDashboard (dashboard_page.ts:480:5)\r\n[00:09:34] │ at Context.<anonymous> (dashboard_integration.ts:87:9)\r\n[00:09:34] │ at Object.apply (wrap_function.js:73:16)\r\n[00:09:34] │ at onFailure (retry_for_success.ts:17:9)\r\n[00:09:34] │ at retryForSuccess (retry_for_success.ts:59:13)\r\n[00:09:34] │ at RetryService.try (retry.ts:31:12)\r\n[00:09:34] │ at DashboardPageObject.saveDashboard (dashboard_page.ts:480:5)\r\n[00:09:34] │ at Context.<anonymous> (dashboard_integration.ts:87:9)\r\n[00:09:34] │ at Object.apply (wrap_function.js:73:16)\r\n[00:09:34] │ \r\n[00:09:34] │ \r\n```","sha":"d3a8699f65d426e738ac742d842226867fe65c8c"}}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
Fixes #160583
Test failed because combobox trying to select already selected tag. PR fixes test by using combobox service to set element. Combobox service includes logic to only select value when not selected.