-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security] [Misconfiguration] Add Grouping custom renderers #172256
[Cloud Security] [Misconfiguration] Add Grouping custom renderers #172256
Conversation
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, works great!. code-wise lgtm, a couple of nit comments
requesting change just because the e2e tests are commented out
x-pack/plugins/cloud_security_posture/public/common/utils/get_abbreviated_number.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/cloud_security_posture/public/common/utils/get_abbreviated_number.ts
Show resolved
Hide resolved
x-pack/plugins/cloud_security_posture/public/pages/configurations/latest_findings/constants.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
This PR adds custom rendering for each of the default Grouping visualizations:
It also adds:
size
property to theComplianceScoreBar
componentScreenshot
Resource
Rule name
Cloud account
Kubernetes
Custom field: