Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] [Misconfiguration] Add Grouping custom renderers #172256

Merged
merged 78 commits into from
Dec 1, 2023

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented Nov 30, 2023

Summary

This PR adds custom rendering for each of the default Grouping visualizations:

It also adds:

  • Fix error handling (follow up from this comment)
  • Change the Findings page to have the Misconfiguration tab in the first position.
  • Added size property to the ComplianceScoreBar component
  • Custom message for groups that don't have value (ex. No Cloud accounts)
  • Changed the sort order of grouping components to be based on the compliance score
  • Added compliance score for custom renderers

Screenshot

Resource

image

Rule name

image

Cloud account

image image

Kubernetes

image

Custom field:

image

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works great!. code-wise lgtm, a couple of nit comments
requesting change just because the e2e tests are commented out

@opauloh opauloh requested a review from maxcold December 1, 2023 20:10
Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 425 429 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 434.5KB 443.7KB +9.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment