Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] [Findings++ Phase 2] [Misconfigurations] Custom Group renderer for Resource #168543

Closed
1 of 2 tasks
opauloh opened this issue Oct 11, 2023 · 3 comments · Fixed by #172256
Closed
1 of 2 tasks

[Cloud Security] [Findings++ Phase 2] [Misconfigurations] Custom Group renderer for Resource #168543

opauloh opened this issue Oct 11, 2023 · 3 comments · Fixed by #172256
Assignees
@opauloh
Labels
8.12 candidate Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related verified

Comments

@opauloh
Copy link
Contributor

opauloh commented Oct 11, 2023 •
edited
Loading

Motivation

When grouping by Resource, the group component shows a title on the left with badges with counters in the grouped row

Definition of done

  • Custom rendering for Group by Resource, based on the Mock provided
  • In the Grouping by resource view there is a horizontal bar chart with failed vs total findings for each group.

Out of scope

  • Custom rendering for other group views
  • Images will be done in a separate ticket

Team tag

@elastic/kibana-cloud-security-posture

Image

Related tasks/epics

Additional improvements to be done as part of this PR
Preview Give feedback
@opauloh opauloh added Team:Cloud Security Cloud Security team related 8.12 candidate labels Oct 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@opauloh opauloh self-assigned this Oct 11, 2023
@opauloh opauloh changed the title [Cloud Security] [Findings++ Phase 2] Custom renderer for Grouped View [Cloud Security] [Findings++ Phase 2] Custom renderer for Findings Grouped Views Oct 11, 2023
@opauloh opauloh changed the title [Cloud Security] [Findings++ Phase 2] Custom renderer for Findings Grouped Views [Cloud Security] [Findings++ Phase 2] [Misconfigurations] Custom Group renderer for Resource Oct 11, 2023
This was referenced Oct 16, 2023
Closed
Closed
Closed
@kfirpeled kfirpeled added the Feature:Cloud-Security Cloud Security related features label Nov 5, 2023
@opauloh opauloh mentioned this issue Nov 30, 2023
Merged
opauloh added a commit that referenced this issue Dec 1, 2023
@opauloh @kibanamachine
[Cloud Security] [Misconfiguration] Add Grouping custom renderers (#1…
0d17a94 
…72256)

## Summary

This PR adds custom rendering for each of the default Grouping
visualizations:

- #168543
- #169043
- #169044
- #169045

**It also adds:**

- Fix error handling (follow up from [this
comment](#169884 (comment)))
- Change the Findings page to have the Misconfiguration tab in the first
position.
- Added `size` property to the `ComplianceScoreBar` component
- Custom message for groups that don't have value (ex. No Cloud
accounts)
- Changed the sort order of grouping components to be based on the
compliance score
- Added compliance score for custom renderers

### Screenshot

Resource

<img width="1492" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/596f8bdb-abcc-4325-8512-23c919c727a9">

Rule name

<img width="1489" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/787138e3-b3b2-4e15-811a-84c583831469">

Cloud account

<img width="1490" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/9a48145d-dba5-4eda-bd7d-a97ed8f78a2d">

<img width="1492" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/399d0be0-4bc0-4090-ac20-e4b016cc4be5">



Kubernetes

<img width="1499" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/3745498a-969a-4769-b4ae-3c932511a5a9">

Custom field:

<img width="1488" alt="image"
src="https://github.com/elastic/kibana/assets/19270322/8c75535d-2248-4cf9-b1cb-9b0d318114e9">

---------

Co-authored-by: kibanamachine <[email protected]>
@opauloh opauloh linked a pull request Dec 1, 2023 that will close this issue
[Cloud Security] [Misconfiguration] Add Grouping custom renderers #172256
Merged
@opauloh
Copy link
Contributor Author

opauloh commented Dec 1, 2023

completed by #172256

@opauloh opauloh closed this as completed Dec 1, 2023
@CohenIdo
Copy link
Contributor

CohenIdo commented Dec 12, 2023 •
edited
Loading

8.12 BC1, QA cycle: verified
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@opauloh opauloh

Labels
8.12 candidate Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cloud Security] [Misconfiguration] Add Grouping custom renderers opauloh/kibana
4 participants
@elasticmachine @opauloh @kfirpeled @CohenIdo