Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud] Rename "Endpoints" to "Connection details" #171982

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Nov 27, 2023

In this PR I've renamed the previous "Endpoints" link to "Connection details" (see issue for details).

How to test

  • Add the following in kibana.yml
xpack.cloud.id: "ftr_fake_cloud_id:aGVsbG8uY29tOjQ0MyRFUzEyM2FiYyRrYm4xMjNhYmM="
  • Modify the maybe_add_cloud_links file
--- a/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts
+++ b/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts
@@ -26,6 +26,7 @@ export function maybeAddCloudLinks({ core, security, cloud, share }: MaybeAddClo
   const userObservable = defer(() => security.authc.getCurrentUser()).pipe(
     // Check if user is a cloud user.
     map((user) => user.elastic_cloud_user),
+    map(() => true),
     // If user is not defined due to an unexpected error, then fail *open*.
     catchError(() => of(true)),
     filter((isElasticCloudUser) => isElasticCloudUser === true),
  • Launch Kibana and open the "help" menu: check that the link & modal are correct
  • Navigate to the "Integrations" page and check that the "Cloud details" link is correct

Screenshots

Screenshot 2023-11-27 at 12 51 38 Screenshot 2023-11-27 at 12 51 48 Screenshot 2023-11-27 at 12 51 23

Fixes #171356

@sebelga sebelga self-assigned this Nov 27, 2023
Copy link
Contributor

Documentation preview:

@sebelga sebelga added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) release_note:skip Skip the PR/issue when compiling release notes labels Nov 27, 2023
@sebelga sebelga marked this pull request as ready for review November 27, 2023 13:02
@sebelga sebelga requested review from a team as code owners November 27, 2023 13:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@sebelga sebelga requested a review from eokoneyo November 27, 2023 13:03
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@eokoneyo eokoneyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally, change set changes endpoint text to connection details in help popover, and integrations page!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Osquery Cypress Tests #3 / Alert Event Details - Cases Case "before each" hook for "sees osquery results from last action and add to a case" "before each" hook for "sees osquery results from last action and add to a case"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB -20.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudLinks 16.0KB 16.0KB +42.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sebelga

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes 🚀

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes 🚀

@sebelga sebelga merged commit 192519d into elastic:main Nov 27, 2023
2 checks passed
@sebelga sebelga deleted the cloud/rename_endpoints_link branch November 27, 2023 15:58
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 27, 2023
@osmanis
Copy link

osmanis commented Nov 30, 2023

@sebelga The text should read Connection details, not >_ Connection details. Can you please update?

@sebelga
Copy link
Contributor Author

sebelga commented Dec 4, 2023

@osmanis Sure, done in #172483

@osmanis
Copy link

osmanis commented Dec 5, 2023

@sebelga Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename >_ Endpoints to Connection details
9 participants