Skip to content

Commit

Permalink
[Cloud] Rename "Endpoints" to "Connection details" (#171982)
Browse files Browse the repository at this point in the history
  • Loading branch information
sebelga authored Nov 27, 2023
1 parent 3a5bb45 commit 192519d
Show file tree
Hide file tree
Showing 10 changed files with 25 additions and 29 deletions.
4 changes: 2 additions & 2 deletions docs/setup/connect-to-elasticsearch.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ Details for each programming language library that Elastic provides are in the
https://www.elastic.co/guide/en/elasticsearch/client/index.html[{es} Client documentation].

If you are running {kib} on our hosted {es} Service,
click *Endpoints* on the *Integrations* view
click *Connection details* on the *Integrations* view
to verify your {es} endpoint and Cloud ID, and create API keys for integration.
Alternatively, the *Endpoints* are also accessible through the top bar help menu.
Alternatively, the *Connection details* are also accessible through the top bar help menu.

[float]
=== Add sample data
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ export const DeploymentDetailsModal: FC<Props> = ({ closeModal }) => {
>
<EuiModalHeader>
<EuiModalHeaderTitle>
{i18n.translate('cloud.deploymentDetails.helpMenuLinks.endpoints', {
defaultMessage: 'Endpoints',
{i18n.translate('cloud.deploymentDetails.helpMenuLinks.connectionDetails', {
defaultMessage: 'Connection details',
})}
</EuiModalHeaderTitle>
</EuiModalHeader>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ interface Props {
share: SharePluginStart;
}

export const EndpointsModal = ({ core, share, cloud, docLinks, closeModal }: Props) => {
export const ConnectionDetailsModal = ({ core, share, cloud, docLinks, closeModal }: Props) => {
return (
<DeploymentDetailsKibanaProvider core={core} share={share} cloud={cloud} docLinks={docLinks}>
<DeploymentDetailsModal closeModal={closeModal} />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import type { CloudStart } from '@kbn/cloud-plugin/public';
import type { SharePluginStart } from '@kbn/share-plugin/public';
import { toMountPoint } from '@kbn/react-kibana-mount';

import { EndpointsModal } from './endpoints_modal';
import { ConnectionDetailsModal } from './connection_details_modal';

export const createHelpMenuLinks = ({
docLinks,
Expand Down Expand Up @@ -50,15 +50,15 @@ export const createHelpMenuLinks = ({
href: docLinks.links.kibana.feedback,
},
{
title: i18n.translate('xpack.cloudLinks.helpMenuLinks.endpoints', {
defaultMessage: 'Endpoints',
title: i18n.translate('xpack.cloudLinks.helpMenuLinks.connectionDetails', {
defaultMessage: 'Connection details',
}),
iconType: 'console',
dataTestSubj: 'endpointsHelpLink',
dataTestSubj: 'connectionDetailsHelpLink',
onClick: () => {
const modal = overlays.openModal(
toMountPoint(
<EndpointsModal
<ConnectionDetailsModal
core={core}
share={share}
cloud={cloud}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ describe('maybeAddCloudLinks', () => {
"title": "Give feedback",
},
Object {
"dataTestSubj": "endpointsHelpLink",
"dataTestSubj": "connectionDetailsHelpLink",
"iconType": "console",
"onClick": [Function],
"title": "Endpoints",
"title": "Connection details",
},
],
]
Expand Down Expand Up @@ -168,10 +168,10 @@ describe('maybeAddCloudLinks', () => {
"title": "Give feedback",
},
Object {
"dataTestSubj": "endpointsHelpLink",
"dataTestSubj": "connectionDetailsHelpLink",
"iconType": "console",
"onClick": [Function],
"title": "Endpoints",
"title": "Connection details",
},
],
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ export const DeploymentDetails = () => {
}

const button = (
<EuiHeaderLink onClick={() => setIsOpen(!isOpen)} iconType="iInCircle" iconSide="left" isActive>
{i18n.translate('xpack.fleet.integrations.endpointsButton', {
defaultMessage: 'Endpoints',
<EuiHeaderLink onClick={() => setIsOpen(!isOpen)} isActive>
{i18n.translate('xpack.fleet.integrations.connectionDetailsButton', {
defaultMessage: 'Connection details',
})}
</EuiHeaderLink>
);
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -17892,7 +17892,6 @@
"xpack.fleet.initializationErrorMessageTitle": "Initialisation de Fleet impossible",
"xpack.fleet.integrations.customInputsLink": "entrées personnalisées",
"xpack.fleet.integrations.discussForumLink": "forum",
"xpack.fleet.integrations.endpointsButton": "Points de terminaison",
"xpack.fleet.integrations.installPackage.uploadedTooltip": "Cette intégration a été installée par le biais d'un chargement et ne peut pas être réinstallée automatiquement. Veuillez la charger à nouveau pour la réinstaller.",
"xpack.fleet.integrations.integrationSaved": "Paramètres de l'intégration enregistrés",
"xpack.fleet.integrations.integrationSavedError": "Erreur lors de l’enregistrement des paramètres de l'intégration",
Expand Down Expand Up @@ -43013,7 +43012,6 @@
"cloud.deploymentDetails.cloudIDLabel": "Identifiant du cloud",
"cloud.deploymentDetails.createManageApiKeysButtonLabel": "Créer et gérer des clés d'API",
"cloud.deploymentDetails.elasticEndpointLabel": "Point de terminaison Elastic",
"cloud.deploymentDetails.helpMenuLinks.endpoints": "Points de terminaison",
"cloud.deploymentDetails.learnMoreButtonLabel": "En savoir plus",
"cloud.deploymentDetails.modal.closeButtonLabel": "Fermer",
"cloud.deploymentDetails.modal.learnMoreButtonLabel": "En savoir plus",
Expand Down Expand Up @@ -43603,7 +43601,6 @@
"xpack.cloudDataMigration.upgrade.text": "Effectuer la mise à niveau vers les versions plus récentes beaucoup plus facilement",
"xpack.cloudLinks.deploymentLinkLabel": "Gérer ce déploiement",
"xpack.cloudLinks.helpMenuLinks.documentation": "Documentation",
"xpack.cloudLinks.helpMenuLinks.endpoints": "Points de terminaison",
"xpack.cloudLinks.helpMenuLinks.giveFeedback": "Donner un retour",
"xpack.cloudLinks.helpMenuLinks.support": "Support technique",
"xpack.cloudLinks.setupGuide": "Guides de configuration",
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -17905,7 +17905,6 @@
"xpack.fleet.initializationErrorMessageTitle": "Fleet を初期化できません",
"xpack.fleet.integrations.customInputsLink": "カスタム入力",
"xpack.fleet.integrations.discussForumLink": "フォーラム",
"xpack.fleet.integrations.endpointsButton": "エンドポイント",
"xpack.fleet.integrations.installPackage.uploadedTooltip": "この統合はアップロードによってインストールされたため、自動的に再インストールできません。再インストールするには、もう一度アップロードしてください。",
"xpack.fleet.integrations.integrationSaved": "統合設定が保存されました",
"xpack.fleet.integrations.integrationSavedError": "統合設定の保存エラー",
Expand Down Expand Up @@ -43003,7 +43002,6 @@
"cloud.deploymentDetails.cloudIDLabel": "クラウドID",
"cloud.deploymentDetails.createManageApiKeysButtonLabel": "APIキーの作成と管理",
"cloud.deploymentDetails.elasticEndpointLabel": "Elastic Endpoint",
"cloud.deploymentDetails.helpMenuLinks.endpoints": "エンドポイント",
"cloud.deploymentDetails.learnMoreButtonLabel": "詳細",
"cloud.deploymentDetails.modal.closeButtonLabel": "閉じる",
"cloud.deploymentDetails.modal.learnMoreButtonLabel": "詳細",
Expand Down Expand Up @@ -43593,7 +43591,6 @@
"xpack.cloudDataMigration.upgrade.text": "新しいバージョンへのアップグレードがより簡単に",
"xpack.cloudLinks.deploymentLinkLabel": "このデプロイの管理",
"xpack.cloudLinks.helpMenuLinks.documentation": "ドキュメント",
"xpack.cloudLinks.helpMenuLinks.endpoints": "エンドポイント",
"xpack.cloudLinks.helpMenuLinks.giveFeedback": "フィードバックを作成する",
"xpack.cloudLinks.helpMenuLinks.support": "サポート",
"xpack.cloudLinks.setupGuide": "セットアップガイド",
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -17905,7 +17905,6 @@
"xpack.fleet.initializationErrorMessageTitle": "无法初始化 Fleet",
"xpack.fleet.integrations.customInputsLink": "定制输入",
"xpack.fleet.integrations.discussForumLink": "论坛",
"xpack.fleet.integrations.endpointsButton": "终端",
"xpack.fleet.integrations.installPackage.uploadedTooltip": "此集成通过上传进行安装,因此无法自动重新安装。请再次将其上传,以便重新安装。",
"xpack.fleet.integrations.integrationSaved": "已保存集成设置",
"xpack.fleet.integrations.integrationSavedError": "保存集成设置时出错",
Expand Down Expand Up @@ -42997,7 +42996,6 @@
"cloud.deploymentDetails.cloudIDLabel": "云 ID",
"cloud.deploymentDetails.createManageApiKeysButtonLabel": "创建和管理 API 密钥",
"cloud.deploymentDetails.elasticEndpointLabel": "Elastic 终端",
"cloud.deploymentDetails.helpMenuLinks.endpoints": "终端",
"cloud.deploymentDetails.learnMoreButtonLabel": "了解详情",
"cloud.deploymentDetails.modal.closeButtonLabel": "关闭",
"cloud.deploymentDetails.modal.learnMoreButtonLabel": "了解详情",
Expand Down Expand Up @@ -43587,7 +43585,6 @@
"xpack.cloudDataMigration.upgrade.text": "更轻松地升级到较新版本",
"xpack.cloudLinks.deploymentLinkLabel": "管理此部署",
"xpack.cloudLinks.helpMenuLinks.documentation": "文档",
"xpack.cloudLinks.helpMenuLinks.endpoints": "终端",
"xpack.cloudLinks.helpMenuLinks.giveFeedback": "反馈",
"xpack.cloudLinks.helpMenuLinks.support": "支持",
"xpack.cloudLinks.setupGuide": "设置指南",
Expand Down
11 changes: 8 additions & 3 deletions x-pack/test/functional_cloud/tests/cloud_links.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,16 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

it('A button to open a modal to view the CloudID and ES endpoint is added', async () => {
await PageObjects.common.clickAndValidate('helpMenuButton', 'endpointsHelpLink');
expect(await find.byCssSelector('[data-test-subj="endpointsHelpLink"]')).to.not.be(null);
await PageObjects.common.clickAndValidate('helpMenuButton', 'connectionDetailsHelpLink');
expect(await find.byCssSelector('[data-test-subj="connectionDetailsHelpLink"]')).to.not.be(
null
);

// Open the modal
await PageObjects.common.clickAndValidate('endpointsHelpLink', 'deploymentDetailsModal');
await PageObjects.common.clickAndValidate(
'connectionDetailsHelpLink',
'deploymentDetailsModal'
);

const esEndpointInput = await find.byCssSelector(
'[data-test-subj="deploymentDetailsEsEndpoint"]'
Expand Down

0 comments on commit 192519d

Please sign in to comment.