-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shareable saved objects] Add Spaces column to TableListView component #170359
Closed
nickpeihl
wants to merge
28
commits into
elastic:shareable-dashboards
from
nickpeihl:spaces-tablelist
Closed
[Shareable saved objects] Add Spaces column to TableListView component #170359
nickpeihl
wants to merge
28
commits into
elastic:shareable-dashboards
from
nickpeihl:spaces-tablelist
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See MSearch developer example under Content Management
…nto spaces-tablelist
…nto spaces-tablelist
… src/core/server/integration_tests/ci_checks'
…nto spaces-tablelist
This reverts commit 6fecfef.
9 tasks
…nto spaces-tablelist
Rescoping this PR into smaller PRs starting with #171223. |
Re-opening this draft PR to create a testing environment in cloud. cc @teresaalvarezsoler @cqliu1 |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Closing this as priorities have shifted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:cloud-deploy
Create or update a Cloud deployment
ci:cloud-redeploy
Always create a new Cloud deployment
Project:ShareToSpace
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only used for creating a testing environment for Shareable Analytics Objects. DO NOT MERGE!
Summary
Adds the a Spaces column to the TableListView component used by Dashboard, Lens, Maps, etc.
The Spaces column shows the Spaces List component for shareable saved objects. This PR is based on the the
shareable-dashboards
feature branch which makes Dashboards, Lens, Maps, and other saved object types shareable across Spaces.Try the Content Management - MSearch developer example to see the Spaces column in action.
yarn start --run-examples
Additional commits will add the Spaces column to applications using the TableListView component.
Discover
SavedObjectsFinder
Other table lists that may be migrated to the TableListView component
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers