Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shareable saved objects] Add Spaces column to TableListView component #170359

Closed

Conversation

nickpeihl
Copy link
Member

@nickpeihl nickpeihl commented Nov 1, 2023

This PR is only used for creating a testing environment for Shareable Analytics Objects. DO NOT MERGE!

Summary

Adds the a Spaces column to the TableListView component used by Dashboard, Lens, Maps, etc.

The Spaces column shows the Spaces List component for shareable saved objects. This PR is based on the the shareable-dashboards feature branch which makes Dashboards, Lens, Maps, and other saved object types shareable across Spaces.

Try the Content Management - MSearch developer example to see the Spaces column in action.

  1. yarn start --run-examples
  2. Create some new Spaces such as "Engineering", "Marketing", "Product".
  3. Add one or more Sample data
  4. Open the MSearch Demo developer example at http://localhost:5601/app/contentManagementExamples/msearch
  5. Click the icon in the Spaces list component to open the Share to Space flyout where the item can be shared to multiple Spaces.
  6. Notice all related objects are also shared.
Screenshot 2023-11-01 at 4 27 31 PM

Additional commits will add the Spaces column to applications using the TableListView component.

  • Annotation groups
  • Dashboard
  • Files
  • Maps
  • Visualizations

Discover

  • Add Spaces column to SavedObjectsFinder

Other table lists that may be migrated to the TableListView component

  • Data views
  • Tags
  • ...

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@nickpeihl nickpeihl added the ci:cloud-deploy Create or update a Cloud deployment label Nov 7, 2023
@nickpeihl
Copy link
Member Author

Rescoping this PR into smaller PRs starting with #171223.

@nickpeihl nickpeihl closed this Nov 14, 2023
@nickpeihl
Copy link
Member Author

Re-opening this draft PR to create a testing environment in cloud. cc @teresaalvarezsoler @cqliu1

@nickpeihl nickpeihl reopened this Nov 27, 2023
@nickpeihl nickpeihl added the ci:cloud-redeploy Always create a new Cloud deployment label Nov 27, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 27, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #10 / Agents fleet_list_agent should return metrics if available and called with withMetrics
  • [job] [logs] FTR Configs #10 / Agents fleet_list_agent should return metrics if available and called with withMetrics
  • [job] [logs] FTR Configs #59 / management index management index templates get all should list all the index templates with the expected parameters
  • [job] [logs] FTR Configs #59 / management index management index templates get all should list all the index templates with the expected parameters
  • [job] [logs] Jest Tests #5 / OpenSearchPanel render
  • [job] [logs] Investigations - Security Solution Cypress Tests #4 / Save Timeline Prompts "before each" hook for "Changed & unsaved timeline should prompt when user navigates away within security solution where timelines are disabled eg. admin screen" "before each" hook for "Changed & unsaved timeline should prompt when user navigates away within security solution where timelines are disabled eg. admin screen"

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [3e64193]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickpeihl
Copy link
Member Author

Closing this as priorities have shifted.

@nickpeihl nickpeihl closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment Project:ShareToSpace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants