-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shareable Dashboards] Make image embeddable shareable #169870
base: main
Are you sure you want to change the base?
Conversation
5d30c54
to
ca61a8e
Compare
getTitle(obj) { | ||
return `${obj.attributes.name}.${obj.attributes.extension}`; | ||
}, | ||
importableAndExportable: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently files don't support export/import, as besides exporting the metadata saved object we would also need to copy the file blob contents. From my understanding it can be achieved, but we would need to implement that first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to set importableAndExportable: false
and won't be tackling support for import/export as part of this PR/sharing dashboards feature. After testing, it seems the combination of hidden: true
and importableAndExportable: false
allows files to be shared but prevents file objects from appearing in the Saved Object Management page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since file objects are hidden from the Saved Object Management page, there is no way in the UI to share files to other Spaces. To resolve this we need to add the "Spaces" column to the filesManagement
page. I have a PoC PR that shows how we could eventually implement that feature. But I don't see why that should block this PR going into the feature branch.
f82528d
to
81beebd
Compare
Pinging @elastic/appex-sharedux (Team:SharedUX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shared ux changes LGTM - code review only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
code review and tested sharing files to multiple spaces with image embeddable
type: 'image', | ||
}; | ||
|
||
expect(inject!(state, references)).toEqual(result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice tests! 💯
… src/core/server/integration_tests/ci_checks'
Pinging @elastic/kibana-presentation (Team:Presentation) |
Sorry for the pings everyone. I rebased this PR and am targeting main as a full feature independent of the shareable dashboard work. Instead of merging this as is, I'm waiting until #169870 is done, so we can enable sharing on the files management page and follow up with additional functional tests. |
Summary
Note: this PR is merging into this Feature Branch: #168166This will be merged into main now.
Blocked by #171461.
Closes #170770.
This enables sharing for image embeddables and file saved objects.
Copy to spaces and import/export of a file saved object doesn't currently work and is not within the scope of this PR.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers