Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uiSettings] Extend toast lifetime #169899

Merged
merged 6 commits into from
Nov 9, 2023
Merged

[uiSettings] Extend toast lifetime #169899

merged 6 commits into from
Nov 9, 2023

Conversation

willie-hung
Copy link
Contributor

@willie-hung willie-hung commented Oct 25, 2023 •
edited
Loading

Summary

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@willie-hung
Extend toast lifetime to 15s
6ba0d21 
Signed-off-by: Willie Hung <[email protected]>
@willie-hung willie-hung requested review from a team as code owners October 25, 2023 23:28
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Oct 25, 2023 •
edited
Loading

💚 CLA has been signed

@eokoneyo eokoneyo added the release_note:skip Skip the PR/issue when compiling release notes label Oct 26, 2023
@pgayvallet pgayvallet added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Oct 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

vadimkibana
vadimkibana approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@vadimkibana vadimkibana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@vadimkibana vadimkibana self-assigned this Nov 2, 2023
@vadimkibana
Copy link
Contributor

buildkite test this

@vadimkibana
Copy link
Contributor

@kibanamachine buildkite test this

@vadimkibana
Copy link
Contributor

/run kibana-ci

@vadimkibana
Copy link
Contributor

@elasticmachine merge upstream

@yuliacech yuliacech self-requested a review November 2, 2023 11:07
yuliacech
yuliacech approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for addressing this issue, @Willie-The-Lord!
Even though the suggestion in the issue was to set the new duration for the callout to 15s or 30s, I think the value of 15s is more than enough after testing locally.

@vadimkibana vadimkibana enabled auto-merge (squash) November 2, 2023 11:41
@vadimkibana
Copy link
Contributor

@elasticmachine merge upstream

auto-merge was automatically disabled November 7, 2023 05:06

Merge queue setting changed

@vadimkibana
Copy link
Contributor

@elasticmachine merge upstream

@vadimkibana
Copy link
Contributor

buildkite test this

@vadimkibana
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 53.2KB 53.2KB +21.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vadimkibana

@vadimkibana vadimkibana merged commit 0cb8a48 into elastic:main Nov 9, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 9, 2023
@willie-hung willie-hung deleted the issue135950 branch November 9, 2023 20:49
@logeekal logeekal mentioned this pull request Nov 16, 2023
Closed
This was referenced Dec 18, 2023
Closed
Merged
ElenaStoeva added a commit that referenced this pull request Jan 8, 2024
@ElenaStoeva @kibanamachine
[Advanced Settings][Serverless] Extend reload page toast lifetime (#1…
55f9417 
…73563)

Addresses #172922

## Summary

This PR extends the "Reload page" toast lifetime to 15s (it was 5s
before). This change was added to the original (stateful) Advanced
settings plugin with #169899 and
we need to also add it to the new Settings packages before we integrate
them into stateful Kibana.

Co-authored-by: Kibana Machine <[email protected]>
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
@ElenaStoeva @kibanamachine @delanni
[Advanced Settings][Serverless] Extend reload page toast lifetime (el…
94e5117 
…astic#173563)

Addresses elastic#172922

## Summary

This PR extends the "Reload page" toast lifetime to 15s (it was 5s
before). This change was added to the original (stateful) Advanced
settings plugin with elastic#169899 and
we need to also add it to the new Settings packages before we integrate
them into stateful Kibana.

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimkibana vadimkibana vadimkibana approved these changes

@yuliacech yuliacech yuliacech approved these changes

Assignees

@vadimkibana vadimkibana

Labels
backport:skip This commit does not require backporting 💝community Feature:uiSettings release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[uiSettings] Page reload toast should remain on screen longer
8 participants
@willie-hung @kibanamachine @elasticmachine @vadimkibana @kibana-ci @yuliacech @pgayvallet @eokoneyo