Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Advanced Settings][Serverless] Extend reload page toast lifetime #173563

Conversation

ElenaStoeva
Copy link
Contributor

Addresses #172922

Summary

This PR extends the "Reload page" toast lifetime to 15s (it was 5s before). This change was added to the original (stateful) Advanced settings plugin with #169899 and we need to also add it to the new Settings packages before we integrate them into stateful Kibana.

@ElenaStoeva ElenaStoeva added Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes labels Dec 18, 2023
@ElenaStoeva ElenaStoeva self-assigned this Dec 18, 2023
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner December 18, 2023 18:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Verified locally.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
management 75.1KB 75.1KB +21.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

@ElenaStoeva ElenaStoeva merged commit 55f9417 into elastic:main Jan 8, 2024
19 checks passed
@ElenaStoeva ElenaStoeva deleted the advanced-settings/reload-page-toast-lifetime branch January 8, 2024 11:28
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 8, 2024
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
…astic#173563)

Addresses elastic#172922

## Summary

This PR extends the "Reload page" toast lifetime to 15s (it was 5s
before). This change was added to the original (stateful) Advanced
settings plugin with elastic#169899 and
we need to also add it to the new Settings packages before we integrate
them into stateful Kibana.

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants