Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shareable dashboards] Make image embeddable shareable #170770

Closed
Tracked by #167901
, #188573
...
cqliu1 opened this issue Nov 7, 2023 · 3 comments · May be fixed by #169870
Closed
Tracked by #167901
, #188573
...

[Shareable dashboards] Make image embeddable shareable #170770

cqliu1 opened this issue Nov 7, 2023 · 3 comments · May be fixed by #169870
Assignees
@cqliu1
Labels
Feature:Dashboard Dashboard related features feature:Files impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:ShareToSpace Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@cqliu1
Copy link
Contributor

cqliu1 commented Nov 7, 2023 •
edited
Loading

Related to #167474.
Blocked by #169870.

Currently, image panels on a shared dashboard are not actually shared across spaces.

Image embeddables are by-value only, so I initially thought they'd be automatically shareable once enabling sharing for dashboards. However I discovered sharing for images was broken because the image embeddable doesn't handle extracting and injecting its references to file saved objects, so the actual image files wouldn't render in other spaces it was shared to.

We need to define inject/extract handlers for the image embeddable so file saved objects can be shared.

We also need to enable sharing for file saved objects.
@cqliu1 cqliu1 added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:ShareToSpace labels Nov 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@cqliu1 cqliu1 changed the title [Sharing dashboards] Making image embeddable shareable [Shareable dashboards] Making image embeddable shareable Nov 7, 2023
@cqliu1 cqliu1 mentioned this issue Nov 7, 2023
Open
@cqliu1 cqliu1 changed the title [Shareable dashboards] Making image embeddable shareable [Shareable dashboards] Make image embeddable shareable Nov 7, 2023
@cqliu1 cqliu1 self-assigned this Nov 7, 2023
@cqliu1 cqliu1 mentioned this issue Nov 9, 2023
Draft
9 tasks
@cqliu1 cqliu1 added feature:Files Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Nov 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@cqliu1 cqliu1 mentioned this issue Nov 17, 2023
Closed
@vadimkibana vadimkibana self-assigned this Nov 20, 2023
@vadimkibana vadimkibana removed their assignment Dec 6, 2023
@Dosant Dosant mentioned this issue May 14, 2024
Closed
@nreese
Copy link
Contributor

nreese commented Jul 17, 2024

Closing, issue iceboxed in #188573

@nreese nreese closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
@nreese nreese mentioned this issue Jul 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cqliu1 cqliu1

Labels
Feature:Dashboard Dashboard related features feature:Files impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:ShareToSpace Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Shareable Dashboards] Make image embeddable shareable cqliu1/kibana
4 participants
@nreese @cqliu1 @elasticmachine @vadimkibana