Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObsUX] Fix layout in KeyValueFilterList component #168814

Merged
merged 6 commits into from
Oct 16, 2023
Merged

[ObsUX] Fix layout in KeyValueFilterList component #168814

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7704e10
fix grid in key_value_filter_list component
MiriamAparicio Oct 11, 2023
9012ef6
Merge branch 'main' into 168129-instances-table-ui-fix
MiriamAparicio Oct 13, 2023
6d29127
Merge branch 'main' into 168129-instances-table-ui-fix
MiriamAparicio Oct 13, 2023
3474775
Merge branch 'main' into 168129-instances-table-ui-fix
MiriamAparicio Oct 13, 2023
0281b8d
Merge branch 'main' into 168129-instances-table-ui-fix
MiriamAparicio Oct 16, 2023
9c1814c
Merge branch 'main' into 168129-instances-table-ui-fix
MiriamAparicio Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions x-pack/plugins/apm/public/components/shared/key_value_filter_list/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ const StyledEuiDescriptionList = styled(EuiDescriptionList)`
`${theme.eui.euiSizeS} ${theme.eui.euiSizeS} 0 ${theme.eui.euiSizeS}`};
.descriptionList__title,
.descriptionList__description {
border-bottom: ${({ theme }) => theme.eui.euiBorderThin};
margin-top: 0;
align-items: center;
display: flex;
Expand Down Expand Up @@ -74,21 +73,21 @@ export function KeyValueFilterList({
buttonContent={<AccordionButtonContent icon={icon} title={title} />}
buttonClassName="buttonContentContainer"
>
<StyledEuiDescriptionList type="column">
<StyledEuiDescriptionList type="column" columnWidths={['20%', '80%']}>
{nonEmptyKeyValueList.map(({ key, value, isFilterable }) => {
return (
<Fragment key={key}>
<EuiDescriptionListTitle
className="descriptionList__title"
style={{ width: '20%', height: '40px' }}
style={{ height: '40px' }}
>
<EuiText size="s" style={{ fontWeight: 'bold' }}>
{key}
</EuiText>
</EuiDescriptionListTitle>
<EuiDescriptionListDescription
className="descriptionList__description"
style={{ width: '80%', height: '40px' }}
style={{ height: '40px' }}
>
<EuiFlexGroup
alignItems="baseline"
Expand Down