Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObsUX] Fix layout in KeyValueFilterList component #168814

Merged

Conversation

MiriamAparicio
Copy link
Contributor

Closes #168129

What was done

There was a change in EuiDescriptionList this component was updated to use CSS grid, and was the cause of the misalignment, it's been fixed with the new prop columnWidths
Also, the grid was creating a gap between the borders of the title and description of the list item.
After checking with @boriskirov, we decided to get rid of the border.

BEFORE

image

AFTER

image

@MiriamAparicio MiriamAparicio requested a review from a team as a code owner October 13, 2023 08:36
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@MiriamAparicio MiriamAparicio added the release_note:skip Skip the PR/issue when compiling release notes label Oct 13, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #27 / cloud_security_posture Cloud Posture Dashboard Page Kubernetes Dashboard displays accurate summary compliance score

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.7MB 3.7MB -50.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MiriamAparicio MiriamAparicio merged commit 70d1b26 into elastic:main Oct 16, 2023
@MiriamAparicio MiriamAparicio deleted the 168129-instances-table-ui-fix branch October 16, 2023 11:55
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 16, 2023
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
Closes elastic#168129

### What was done

There was a change in `EuiDescriptionList` this component was updated to
use CSS grid, and was the cause of the misalignment, it's been fixed
with the new prop `columnWidths`
Also, the grid was creating a gap between the borders of the title and
description of the list item.
After checking with @boriskirov, we decided to get rid of the border.

BEFORE


![image](https://github.com/elastic/kibana/assets/31922082/fa2fbf54-08b8-4425-b834-504f2c0d7753)

AFTER


![image](https://github.com/elastic/kibana/assets/31922082/03356522-08aa-474e-a3dd-b39eaf19ec25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Instances table style bug
6 participants