-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ObsUX] Fix layout in KeyValueFilterList component #168814
Merged
MiriamAparicio
merged 6 commits into
elastic:main
from
MiriamAparicio:168129-instances-table-ui-fix
Oct 16, 2023
Merged
[ObsUX] Fix layout in KeyValueFilterList component #168814
MiriamAparicio
merged 6 commits into
elastic:main
from
MiriamAparicio:168129-instances-table-ui-fix
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/apm-ui (Team:APM) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
MiriamAparicio
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Oct 13, 2023
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
sorenlouv
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
kibanamachine
added
v8.12.0
backport:skip
This commit does not require backporting
labels
Oct 16, 2023
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
Closes elastic#168129 ### What was done There was a change in `EuiDescriptionList` this component was updated to use CSS grid, and was the cause of the misalignment, it's been fixed with the new prop `columnWidths` Also, the grid was creating a gap between the borders of the title and description of the list item. After checking with @boriskirov, we decided to get rid of the border. BEFORE ![image](https://github.com/elastic/kibana/assets/31922082/fa2fbf54-08b8-4425-b834-504f2c0d7753) AFTER ![image](https://github.com/elastic/kibana/assets/31922082/03356522-08aa-474e-a3dd-b39eaf19ec25)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:APM
All issues that need APM UI Team support
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168129
What was done
There was a change in
EuiDescriptionList
this component was updated to use CSS grid, and was the cause of the misalignment, it's been fixed with the new propcolumnWidths
Also, the grid was creating a gap between the borders of the title and description of the list item.
After checking with @boriskirov, we decided to get rid of the border.
BEFORE
AFTER