-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds api integration tests for core to serverless common #167570
Adds api integration tests for core to serverless common #167570
Conversation
Pinging @elastic/kibana-core (Team:Core) |
@lukeelmers I added you because I need help with adding custom config dependent tests! |
@@ -24,6 +24,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) { | |||
require.resolve('../../common/scripts_tests'), | |||
require.resolve('../../common/search_oss'), | |||
require.resolve('../../common/search_xpack'), | |||
require.resolve('../../common/core'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main index
file was removed in favor of using common configs (#167172) to specify the common tests to run on each project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self review
const supertest = getService('supertest'); | ||
const svlCommonApi = getService('svlCommonApi'); | ||
describe('/api/core/capabilities', () => { | ||
it(`returns a 400 when an invalid app id is provided`, async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test passed without custom config.
.then((response) => { | ||
expect(response.header).to.have.property('content-encoding', 'gzip'); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other tests we have in test/api_integration/core
are either not applicable to serverless or will be added in a follow-up PR. I'll need to figure out how to add tests that use custom configs.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Remember to reopen the linked issue. It will be closed the moment we merge this one.
Partially fix #167314
This PR adds serverless api_integration tests for
core
as acommon
test run for all project types.The tests I added are modified duplicates of those in
test/api_integration/apis/core
that don't rely on custom configuration.