Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy/link existing FTR tests to test_serverless #167314

Closed
14 of 16 tasks
TinaHeiligers opened this issue Sep 26, 2023 · 9 comments · Fixed by #167570
Closed
14 of 16 tasks

Copy/link existing FTR tests to test_serverless #167314

TinaHeiligers opened this issue Sep 26, 2023 · 9 comments · Fixed by #167570
Labels
chore Project:Serverless Work as part of the Serverless project for its initial release Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Sep 26, 2023

This issue may need to broken into sub-issues. We want to see how much test coverage can easily be ported over to the test_serverless folder. FTR tests of interest:

API integration

  • test/api_integration/apis/core PR #167570
  • test/api_integration/apis/saved_objects SO HTTP APIs removed in serverless
  • (?) test/api_integration/apis/telemetry --> telemetry tests run for each Project type already
  • test/server_integration/* not testing anything that could be a risk for serverless
  • test/plugin_functional/test_suites/saved_objects_hidden_type SO HTTP APIs removed in serverless
  • test/plugin_functional/test_suites/saved_objects_management (maybe API integration tests provide enough coverage and we can skip these?)
  • [core] Add SOM api integration tests for serverless #175757
  • test/health_gateway/tests Not used on serverless

E2E

  • test/functional/apps/bundles
  • x-pack/test/functional_execution_context/plugins/alerts
  • (?) test/node_roles_functional/plugins/core_plugin_initializer_context

Other

  • test/analytics/plugins/analytics_plugin_a
  • x-pack/test/saved_objects_field_count
  • test/analytics/tests
  • test/plugin_functional/test_suites/core
  • test/plugin_functional/test_suites/core_plugins
@TinaHeiligers TinaHeiligers self-assigned this Sep 26, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 26, 2023
@TinaHeiligers TinaHeiligers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Sep 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 26, 2023
@TinaHeiligers TinaHeiligers added chore needs-team Issues missing a team label Serverless labels Sep 26, 2023
@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 26, 2023
@TinaHeiligers
Copy link
Contributor Author

@elastic/kibana-operations do you see any issues with us copying these tests to run for serverless testing?
@elastic/appex-sharedux is your team doing any of this work?

@Ikuni17
Copy link
Contributor

Ikuni17 commented Sep 26, 2023

@TinaHeiligers Some teams are reusing their tests, so it shouldn't be an issue. I haven't looked at your specific tests, but it may be necessary to setup tags to skip in specific environments. For example, if a test is flaky in serverless but not when running normally or if a test just doesn't work in serverless.

@TinaHeiligers
Copy link
Contributor Author

@elastic/kibana-core it looks like we still need to do this work.
I'll get started with test/api_integration/apis/core. If other team members pitch in, we'll get through the list in the description more quickly.

If anyone does help out, please reference this issue in your PR(s) as partially addresses https://github.com/elastic/kibana/issues/167314

@TinaHeiligers
Copy link
Contributor Author

@Ikuni17 I don't know how to use the tags. Where can I find out more?

@TinaHeiligers
Copy link
Contributor Author

the first of many PR's borked, created a new one

@TinaHeiligers
Copy link
Contributor Author

Reopening for other tests that need to be added.

@TinaHeiligers TinaHeiligers reopened this Oct 2, 2023
@TinaHeiligers TinaHeiligers removed their assignment Oct 3, 2023
@TinaHeiligers
Copy link
Contributor Author

Adding the tests identified in the description would be faster if the whole core team worked on this, so I'm unassigning myself here.

@watson watson added Project:Serverless Work as part of the Serverless project for its initial release and removed Serverless labels Oct 4, 2023
@TinaHeiligers
Copy link
Contributor Author

The original list as given in the description is stale. New issues will be opened for tests that need to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Project:Serverless Work as part of the Serverless project for its initial release Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
4 participants