Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Makes shards optional in Create pack API #166639

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Sep 18, 2023

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@github-actions
Copy link
Contributor

Documentation preview:

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- thanks!

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry if I was holding this up. Feel free to ping me directly if you're waiting.

@natasha-moore-elastic natasha-moore-elastic merged commit 62e087a into elastic:main Sep 25, 2023
10 checks passed
@natasha-moore-elastic natasha-moore-elastic deleted the issue-3822-make-shards-optional branch September 25, 2023 10:39
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 25, 2023
## Summary

* Resolves elastic/security-docs#3822.

* Updates the `shards` object in Create pack API to optional for 8.10.1
and 8.11.0 onwards, per elastic#166178

* Related to changes made in
elastic#166363.

(cherry picked from commit 62e087a)
kibanamachine added a commit that referenced this pull request Sep 25, 2023
…7135)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[DOCS] Makes shards optional in Create pack API
(#166639)](#166639)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"natasha-moore-elastic","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-25T10:38:41Z","message":"[DOCS]
Makes shards optional in Create pack API (#166639)\n\n##
Summary\r\n\r\n* Resolves
elastic/security-docs#3822. \r\n\r\n* Updates
the `shards` object in Create pack API to optional for 8.10.1\r\nand
8.11.0 onwards, per
https://github.com/elastic/kibana/pull/166178\r\n\r\n* Related to
changes made
in\r\nhttps://github.com//pull/166363.","sha":"62e087a8a8c7507cd0ead1e54d2db36654c58e60","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v8.10.0","v8.11.0"],"number":166639,"url":"https://github.com/elastic/kibana/pull/166639","mergeCommit":{"message":"[DOCS]
Makes shards optional in Create pack API (#166639)\n\n##
Summary\r\n\r\n* Resolves
elastic/security-docs#3822. \r\n\r\n* Updates
the `shards` object in Create pack API to optional for 8.10.1\r\nand
8.11.0 onwards, per
https://github.com/elastic/kibana/pull/166178\r\n\r\n* Related to
changes made
in\r\nhttps://github.com//pull/166363.","sha":"62e087a8a8c7507cd0ead1e54d2db36654c58e60"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166639","number":166639,"mergeCommit":{"message":"[DOCS]
Makes shards optional in Create pack API (#166639)\n\n##
Summary\r\n\r\n* Resolves
elastic/security-docs#3822. \r\n\r\n* Updates
the `shards` object in Create pack API to optional for 8.10.1\r\nand
8.11.0 onwards, per
https://github.com/elastic/kibana/pull/166178\r\n\r\n* Related to
changes made
in\r\nhttps://github.com//pull/166363.","sha":"62e087a8a8c7507cd0ead1e54d2db36654c58e60"}}]}]
BACKPORT-->

Co-authored-by: natasha-moore-elastic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.10.0 v8.10.3 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation API OSQuery Packs Policy shards feature - partial deployment
5 participants