Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10] fix(slo): Handle partial indicator url state (#167247) #167722

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Oct 1, 2023

Backport

This will backport the following commits from main to 8.10:

But this commit used a RecursivePartial type from a plugin that does not yet exist in 8.10. Therefore I'm fixing this backport by changing the import from eui instead (identical).

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme changed the base branch from main to 8.10 October 1, 2023 11:59
@kdelemme kdelemme marked this pull request as ready for review October 1, 2023 12:11
@kdelemme kdelemme force-pushed the backport/pr-167247 branch from c17240c to 416f578 Compare October 1, 2023 12:41
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.0MB 1.0MB +784.0B

History

  • 💔 Build #164258 failed c17240ccd52298f28f968f9ce64ffc6bf7f29b04

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kdelemme kdelemme self-assigned this Oct 2, 2023
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdelemme kdelemme merged commit 6228c81 into elastic:8.10 Oct 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants