Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit defaultModel generative AI connector description #166405

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Edit defaultModel generative AI connector description #166405

merged 5 commits into from
Sep 25, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 13, 2023 •
edited by kibanamachine
Loading

Summary

Relates to #162204

This PR:

  • Shortens the description for the generative AI connector's default model field
  • Removes a link from the UI to API docs that didn't seem to offer any additional details
  • Updates the documentation to include a description for this new field
  • Fixes the capitalization of "API key"
  • Refreshes the automated screenshot

@github-actions
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl added docs ui-copy Review of UI copy with docs team is recommended v8.1.1 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.1 Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes labels Sep 13, 2023
@lcawl lcawl marked this pull request as ready for review September 14, 2023 14:59
@lcawl lcawl requested review from a team as code owners September 14, 2023 14:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

ymao1
ymao1 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl enabled auto-merge (squash) September 25, 2023 17:19
stephmilovic
stephmilovic approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 468.0KB 467.0KB -1.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 1c427a4 into elastic:main Sep 25, 2023
@kibanamachine kibanamachine mentioned this pull request Sep 25, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 25, 2023
@lcawl
Edit defaultModel generative AI connector description (elastic#166405)
18c08b7 
(cherry picked from commit 1c427a4)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.1 Backport failed because of merge conflicts
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 166405

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl removed the v8.1.1 label Sep 25, 2023
@lcawl lcawl deleted the defaultModel branch September 25, 2023 20:17
lcawl pushed a commit that referenced this pull request Sep 25, 2023
@kibanamachine
[8.10] Edit defaultModel generative AI connector description (#166405) (
71ecbaf 
#167196)
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) ui-copy Review of UI copy with docs team is recommended v8.10.1 v8.10.3 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lcawl @apmmachine @elasticmachine @kibana-ci @kibanamachine @dgieselaar @stephmilovic @ymao1