Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Make landing page links relative #166314

Merged
merged 1 commit into from
Sep 13, 2023
Merged

[DOCS] Make landing page links relative #166314

merged 1 commit into from
Sep 13, 2023

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Sep 12, 2023

Problem:
The below links on the Kibana docs landing page must be updated each major/minor release. We often forget this chore.

Screenshot 2023-09-12 at 7 30 21 PM

Solution:
Make the links relative so they always stay updated.

@github-actions
Copy link
Contributor

Documentation preview:

@jrodewig jrodewig added Team:Docs release_note:skip Skip the PR/issue when compiling release notes docs v8.11.0 v8.10.1 labels Sep 12, 2023
@jrodewig jrodewig marked this pull request as ready for review September 12, 2023 23:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@jrodewig jrodewig requested a review from a team September 12, 2023 23:41
@jrodewig jrodewig changed the title Make landing page links relative [DOCS] Make landing page links relative Sep 12, 2023
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig
Copy link
Contributor Author

Thanks again @abdonpijpelink!

@jrodewig jrodewig merged commit 15d4e42 into elastic:main Sep 13, 2023
@jrodewig jrodewig deleted the make-landing-page-links-relative branch September 13, 2023 09:07
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 13, 2023
**Problem:**
The links on the Kibana docs landing page must be updated each major/minor release. We often forget this chore.

**Solution:**
Make the links relative so they always stay updated.

(cherry picked from commit 15d4e42)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 13, 2023
# Backport

This will backport the following commits from `main` to `8.10`:
- [[DOCS] Make landing page links relative
(#166314)](#166314)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Rodewig","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-13T09:02:50Z","message":"[DOCS]
Make landing page links relative (#166314)\n\n**Problem:**\r\nThe links
on the Kibana docs landing page must be updated each major/minor
release. We often forget this chore.\r\n\r\n**Solution:**\r\nMake the
links relative so they always stay
updated.","sha":"15d4e42a965e5d1758fbe3c6b6490bf7adb942be","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","v8.11.0","v8.10.1"],"number":166314,"url":"https://github.com/elastic/kibana/pull/166314","mergeCommit":{"message":"[DOCS]
Make landing page links relative (#166314)\n\n**Problem:**\r\nThe links
on the Kibana docs landing page must be updated each major/minor
release. We often forget this chore.\r\n\r\n**Solution:**\r\nMake the
links relative so they always stay
updated.","sha":"15d4e42a965e5d1758fbe3c6b6490bf7adb942be"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166314","number":166314,"mergeCommit":{"message":"[DOCS]
Make landing page links relative (#166314)\n\n**Problem:**\r\nThe links
on the Kibana docs landing page must be updated each major/minor
release. We often forget this chore.\r\n\r\n**Solution:**\r\nMake the
links relative so they always stay
updated.","sha":"15d4e42a965e5d1758fbe3c6b6490bf7adb942be"}},{"branch":"8.10","label":"v8.10.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Rodewig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.10.1 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants