Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Unskip Uptime overview page functional tests #163985

Merged
merged 4 commits into from
Aug 16, 2023
Merged

[Synthetics] Unskip Uptime overview page functional tests #163985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abb995a
Unskip Uptime overview page tests.
justinkambic Aug 15, 2023
1642d1c
Merge branch 'main' into 89072/re-enable-overview-tests
kibanamachine Aug 16, 2023
41623e7
Merge branch 'main' into 89072/re-enable-overview-tests
shahzad31 Aug 16, 2023
1fdcfda
Merge branch 'main' into 89072/re-enable-overview-tests
shahzad31 Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions x-pack/test/functional/apps/uptime/overview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

const testSubjects = getService('testSubjects');

// FLAKY: https://github.com/elastic/kibana/issues/89072
describe.skip('overview page', function () {
describe('overview page', function () {
const DEFAULT_DATE_START = 'Sep 10, 2019 @ 12:40:08.078';
const DEFAULT_DATE_END = 'Sep 11, 2019 @ 19:40:08.078';

Expand Down Expand Up @@ -199,7 +198,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

it('can change query syntax to kql', async () => {
await testSubjects.click('switchQueryLanguageButton');
await testSubjects.click('languageToggle');
await testSubjects.click('kqlLanguageMenuItem');
});

it('runs filter query without issues', async () => {
Expand Down
6 changes: 3 additions & 3 deletions x-pack/test/functional/services/uptime/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export function UptimeCommonProvider({ getService, getPageObjects }: FtrProvider
await this.setKueryBarText('queryInput', filterQuery);
},
async goToNextPage() {
await testSubjects.click('xpack.synthetics.monitorList.nextButton', 5000);
await testSubjects.click('xpack.uptime.monitorList.nextButton', 5000);
},
async goToPreviousPage() {
await testSubjects.click('xpack.synthetics.monitorList.prevButton', 5000);
Expand Down Expand Up @@ -97,11 +97,11 @@ export function UptimeCommonProvider({ getService, getPageObjects }: FtrProvider
};
},
async openPageSizeSelectPopover(): Promise<void> {
return testSubjects.click('xpack.synthetics.monitorList.pageSizeSelect.popoverOpen', 5000);
return testSubjects.click('xpack.uptime.monitorList.pageSizeSelect.popoverOpen', 5000);
},
async clickPageSizeSelectPopoverItem(size: number = 10): Promise<void> {
return testSubjects.click(
`xpack.synthetics.monitorList.pageSizeSelect.sizeSelectItem${size.toString()}`,
`xpack.uptime.monitorList.pageSizeSelect.sizeSelectItem${size.toString()}`,
5000
);
},
Expand Down