-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Unskip Uptime overview page functional tests #163985
Merged
awahab07
merged 4 commits into
elastic:main
from
justinkambic:89072/re-enable-overview-tests
Aug 16, 2023
Merged
[Synthetics] Unskip Uptime overview page functional tests #163985
awahab07
merged 4 commits into
elastic:main
from
justinkambic:89072/re-enable-overview-tests
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
release_note:skip
Skip the PR/issue when compiling release notes
v8.10.0
labels
Aug 15, 2023
Pinging @elastic/uptime (Team:uptime) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
justinkambic
force-pushed
the
89072/re-enable-overview-tests
branch
2 times, most recently
from
August 15, 2023 21:52
7e3feff
to
a75c2b6
Compare
justinkambic
force-pushed
the
89072/re-enable-overview-tests
branch
from
August 16, 2023 01:44
a75c2b6
to
abb995a
Compare
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Triggered flaky test runner pipeline here. |
awahab07
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Aug 16, 2023
…3985) ## Summary Updates and unskips the overview page tests. Resolves elastic#89072. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Shahzad <[email protected]>
bryce-b
pushed a commit
that referenced
this pull request
Aug 22, 2023
## Summary Updates and unskips the overview page tests. Resolves #89072. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Shahzad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v8.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates and unskips the overview page tests.
Resolves #89072.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers