Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Unskip Uptime overview page functional tests #163985

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

justinkambic
Copy link
Contributor

Summary

Updates and unskips the overview page tests.

Resolves #89072.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@justinkambic justinkambic added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.10.0 labels Aug 15, 2023
@justinkambic justinkambic self-assigned this Aug 15, 2023
@justinkambic justinkambic requested a review from a team as a code owner August 15, 2023 21:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@justinkambic justinkambic force-pushed the 89072/re-enable-overview-tests branch 2 times, most recently from 7e3feff to a75c2b6 Compare August 15, 2023 21:52
@justinkambic justinkambic force-pushed the 89072/re-enable-overview-tests branch from a75c2b6 to abb995a Compare August 16, 2023 01:44
@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@awahab07
Copy link
Contributor

Triggered flaky test runner pipeline here.

Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@awahab07 awahab07 merged commit 3075883 into elastic:main Aug 16, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 16, 2023
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Aug 16, 2023
…3985)

## Summary

Updates and unskips the overview page tests.

Resolves elastic#89072.

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Shahzad <[email protected]>
@justinkambic justinkambic deleted the 89072/re-enable-overview-tests branch August 16, 2023 14:10
bryce-b pushed a commit that referenced this pull request Aug 22, 2023
## Summary

Updates and unskips the overview page tests.

Resolves #89072.

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.10.0
Projects
None yet
7 participants