[Cases] Improve slow CaseViewPage jest tests #150952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
bug
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
This was
linked to
issues
Feb 10, 2023
| }); | ||
|
|
||
| userEvent.click(result.getByTestId('edit-connectors-submit')); | ||
| expect(await screen.findByTestId('connector-fields-resilient')).toBeInTheDocument(); |
There was a problem hiding this comment.
findByTestId does a waitFor internally so this may be a performance improvement 🤷♂️ maybe more a readability improvement.
There was a problem hiding this comment.
cnasikas
approved these changes
Feb 11, 2023
There was a problem hiding this comment.
This is amazing @jonathan-buttner! I learned so much 🙂. Inspired by @mikecote, maybe you can add a for-loop around the test to run it on the CI multiple times and then remove it to be sure the test is not flaky. Example f9372b2.
|
|
||
| const dropdown = screen.getByTestId('case-view-status-dropdown'); | ||
| userEvent.click(dropdown.querySelector('button')!, undefined, { | ||
| skipPointerEventsCheck: true, |
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
adcoelho
reviewed
Feb 20, 2023
| const license = licensingMock.createLicense({ | ||
| license: { type: 'platinum' }, | ||
| }); | ||
| for (let i = 0; i < 500; i++) { |
There was a problem hiding this comment.
Don't forget to remove this 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 149782, 149781, 149780, 149778, 149779, 149777, 149776, 149775, 149773, 149774, 149772, 149771, 149770, 149769
This PR attempts to speed up some slow tests for the
CaseViewPagecomponent.The
should update connectortest was reporting a failure for exceeding the 5000 timeout. I tried moving some things out of the beforeEach, using screen, and addingskipPointerEventsCheck: truewhich according to the docs can be a performance improvementThe other thing I noticed was that when a test exceeds the timeout it can cause tests after it to fail. I'm not sure why but I was able to reproduce this:
I think that's what's happening with the CI failure here: https://buildkite.com/elastic/kibana-on-merge/builds/26147#0185f527-6859-4d01-ac37-e5483a535e48
Example performance improvements
New performance
Old performance