Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] Try to fix flaky rules_list test - filter by rule state #150056

Merged
merged 10 commits into from
Feb 6, 2023
Merged

[RAM] Try to fix flaky rules_list test - filter by rule state #150056

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2c605bc
remove unnecessary check and wait for element to show
jcger Feb 1, 2023
bc1012b
Merge branch 'main' into 149061-failing-rules-list-test
jcger Feb 1, 2023
72ca150
Merge branch 'main' into 149061-failing-rules-list-test
jcger Feb 2, 2023
a6a9cf2
Merge branch 'main' into 149061-failing-rules-list-test
jcger Feb 2, 2023
c2141db
add back initial check but waiting for spinner to exit
jcger Feb 2, 2023
da91793
Merge branch '149061-failing-rules-list-test' of github.com:jcger/kib…
jcger Feb 2, 2023
b2737bc
Merge branch 'main' into 149061-failing-rules-list-test
jcger Feb 2, 2023
ca7970b
Merge branch 'main' into 149061-failing-rules-list-test
jcger Feb 2, 2023
f16336f
Merge branch 'main' into 149061-failing-rules-list-test
jcger Feb 2, 2023
dc7cbc0
Merge branch 'main' into 149061-failing-rules-list-test
jcger Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...triggers_actions_ui/public/application/sections/rules_list/components/rules_list.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,15 +332,14 @@ describe('rules_list ', () => {
renderWithProviders(
<RulesList statusFilter={['disabled']} onStatusFilterChange={onStatusFilterChangeMock} />
);
await waitFor(() => screen.getByText('Rule state'));
await waitForElementToBeRemoved(() => screen.queryByTestId('centerJustifiedSpinner'));
expect(loadRulesWithKueryFilter).toHaveBeenLastCalledWith(
expect.objectContaining({
ruleStatusesFilter: ['disabled'],
})
);

fireEvent.click(screen.getAllByTestId('ruleStatusFilterButton')[0]);
fireEvent.click(screen.getAllByTestId('ruleStatusFilterOption-enabled')[0]);
fireEvent.click((await screen.findAllByTestId('ruleStatusFilterButton'))[0]);
fireEvent.click((await screen.findAllByTestId('ruleStatusFilterOption-enabled'))[0]);
expect(loadRulesWithKueryFilter).toHaveBeenLastCalledWith(
expect.objectContaining({
ruleStatusesFilter: ['disabled', 'enabled'],
Expand Down