[RAM] Try to fix flaky rules_list test - filter by rule state #150056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcger
added
release_note:skip
…ana into 149061-failing-rules-list-test
|
Pinging @elastic/response-ops (Team:ResponseOps) |
jcger
changed the title
guskovaue
approved these changes
Feb 2, 2023
JiaweiWu
approved these changes
Feb 2, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
sphilipse
pushed a commit
to sphilipse/kibana
that referenced
this pull request
Feb 6, 2023
…c#150056) ## Summary Related to elastic#149061 I won't close the issue with this PR so we can keep getting notified about future fails Updated so it waits until the spinner is gone instead of waiting for "Rule state" text to appear as it's done this way in the rest of the tests and they are not flaky. Instead of assuming that the rule status filter button and it's toolbar are shown from the beginning, we ensure they are present waiting for these elements to appear. (I hope this one was the root cause but we won't be sure until this stops happening)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #149061
I won't close the issue with this PR so we can keep getting notified about future fails
Updated so it waits until the spinner is gone instead of waiting for "Rule state" text to appear as it's done this way in the rest of the tests and they are not flaky.
Instead of assuming that the rule status filter button and it's toolbar are shown from the beginning, we ensure they are present waiting for these elements to appear. (I hope this one was the root cause but we won't be sure until this stops happening)