Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert image names to snake_case in RFC 0020. #103536

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Convert image names to snake_case in RFC 0020. #103536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 rfcs/images/15_clustering/cluster-mode.png → rfcs/images/20_clustering/cluster_mode.png
View file
Open in desktop
File renamed without changes
0 .../images/15_clustering/no-cluster-mode.png → .../images/20_clustering/no_cluster_mode.png
View file
Open in desktop
File renamed without changes
0 rfcs/images/15_clustering/perf-4-workers.png → rfcs/images/20_clustering/perf_4_workers.png
View file
Open in desktop
File renamed without changes
0 ...5_clustering/perf-clustering-2-worker.png → ...0_clustering/perf_clustering_2_worker.png
View file
Open in desktop
File renamed without changes
0 ...ages/15_clustering/perf-no-clustering.png → ...ages/20_clustering/perf_no_clustering.png
View file
Open in desktop
File renamed without changes
10 changes: 5 additions & 5 deletions rfcs/text/0020_nodejs_clustering.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@ container per host CPU with a single Kibana process per container).

In 'classic' mode, the Kibana server is started in the main Node.js process.

![image](../images/15_clustering/no-cluster-mode.png)
![image](../images/20_clustering/no_cluster_mode.png)

In clustering mode, the main Node.js process would only start the coordinator, which would then
fork workers using Node's `cluster` API. Node's underlying socket implementation allows multiple
processes to listen to the same ports, effectively performing http traffic balancing between the
workers for us.

![image](../images/15_clustering/cluster-mode.png)
![image](../images/20_clustering/cluster_mode.png)

The coordinator's primary responsibility is to orchestrate the workers. It would not be a 'super'
worker handling both the job of a worker while being in charge of managing the other workers.
Expand Down Expand Up @@ -97,15 +97,15 @@ Intel Core i9 - 32 GB 2400 MHz DDR4), using the default configuration of the `ki

#### Non-clustered mode

![image](../images/15_clustering/perf-no-clustering.png)
![image](../images/20_clustering/perf_no_clustering.png)

#### Clustered mode, 2 workers

![image](../images/15_clustering/perf-clustering-2-worker.png)
![image](../images/20_clustering/perf_clustering_2_worker.png)

#### Clustered mode, 4 workers

![image](../images/15_clustering/perf-4-workers.png)
![image](../images/20_clustering/perf_4_workers.png)

### 4.1.2 Analysis

Expand Down