Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert image names to snake_case in RFC 0020. #103536

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Convert image names to snake_case in RFC 0020. #103536

merged 1 commit into from
Jun 28, 2021

Conversation

lukeelmers
Copy link
Member

#94057 Broke CI because the image names were not snake_case. This fixes the issue.

@lukeelmers lukeelmers self-assigned this Jun 28, 2021
@lukeelmers lukeelmers requested a review from jbudz June 28, 2021 18:58
@lukeelmers lukeelmers added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Jun 28, 2021
@jbudz
Copy link
Member

jbudz commented Jun 28, 2021

I verified node scripts/check_file_casing locally and that the images still display. Thanks for the quick PR - I'm merging this early to clear up main.

@jbudz jbudz merged commit 928c4b8 into elastic:master Jun 28, 2021
@lukeelmers lukeelmers deleted the fix/rfc-image-names branch June 28, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz Awaiting requested review from jbudz

Assignees

@lukeelmers lukeelmers

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukeelmers @jbudz