Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stateful: Home page] Wrong navigation sequence after Creating API key #195366

Closed
L1nBra opened this issue Oct 8, 2024 · 1 comment · Fixed by #198253
Closed

[Stateful: Home page] Wrong navigation sequence after Creating API key #195366

L1nBra opened this issue Oct 8, 2024 · 1 comment · Fixed by #198253
Assignees
@alexwizp
Labels
defect-level-3 Moderate UX disruption or potentially confusing Project:Accessibility Team:Search WCAG A WCAG AA

Comments

@L1nBra
Copy link

L1nBra commented Oct 8, 2024 •
edited
Loading

Description
Navigation should be clear and in sequence for the user to easily understand how to navigate on the webpage.

Preconditions
Stateful Home page (Overview) is opened.
Use Screen Reader (NVDA).

Steps to reproduce

1.Navigate to New button while using only keyboard by pressing Tab key.
2.Press Enter.
3.Enter any text (f.e.: Test) in Name field.
4.Navigate to Create API Key button.
5.Press Enter key.
6.Observe Screen Reader announcement.
7.Press Tab key.
8.Observe Screen Reader announcement.

UI elements
Image

Image

NVDA Speech Viewer
Image

Actual Result

  • After pressing Enter on Create API Key, Screen Reader announces New button. After pressing Tab key, Screen reader announces dialog information, Create API key button and only then Copy button (even though focus is on Copy button).

Expected Result

  • Focus shouldn't move outside of Create an API key dialog. It should:
    a)stay on Create API Key button but announcement about created API key should be made for the user
    or
    b)it should directly move to Copy button in Store this API key area inside Create an API key dialog, because this section appeared after creating an API key. But in this case announcement about successful creation of API key is also needed, before announcing Copy button.

Meta Issue

Kibana Version: 8.16.0-SNAPSHOT

OS: Windows 11 Pro

Browser: Chrome Version 129.0.6668.70 (Official Build) (64-bit)

Screen reader: NVDA

WCAG or Vendor Guidance (optional)

Related to: https://github.com/elastic/search-team/issues/8256
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 8, 2024
@L1nBra L1nBra added WCAG A WCAG AA impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. defect-level-1 Critical UX disruption defect-level-3 Moderate UX disruption or potentially confusing and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. defect-level-1 Critical UX disruption labels Oct 8, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 10, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 10, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 10, 2024
@L1nBra L1nBra mentioned this issue Oct 11, 2024
Closed
@alexwizp alexwizp self-assigned this Oct 30, 2024
@alexwizp alexwizp mentioned this issue Oct 30, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 5, 2024
@alexwizp
fix: [Stateful: Home page] Missing information of Store this API key …
1023a59 
…section first time (elastic#198253)

Closes: elastic#195382
Closes: elastic#195366

## Description

All information which is accessible for the user should be announced
when the user navigates to the element first time (not only when he
reaches it second, third and so on time).

## What was changed?:

1. added `role="alert"` to correctly pronounce status update. Addind
role attribute also fixes elastic#195366

## Screen:

https://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81
(cherry picked from commit 92ae754)
kibanamachine added a commit that referenced this issue Nov 5, 2024
@kibanamachine @alexwizp
[8.x] fix: [Stateful: Home page] Missing information of Store this AP…
8ff526e 
…I key section first time (#198253) (#199010)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Stateful: Home page] Missing information of Store this API key
section first time
(#198253)](#198253)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T15:38:26Z","message":"fix:
[Stateful: Home page] Missing information of Store this API key section
first time (#198253)\n\nCloses: #195382\r\nCloses: #195366\r\n\r\n##
Description\r\n\r\nAll information which is accessible for the user
should be announced\r\nwhen the user navigates to the element first time
(not only when he\r\nreaches it second, third and so on time).\r\n\r\n##
What was changed?:\r\n\r\n1. added `role=\"alert\"` to correctly
pronounce status update. Addind\r\nrole attribute also fixes
#195366\r\n\r\n\r\n##
Screen:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81","sha":"92ae754ff93b52b742885761afa8b2b7d857ce25","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix:
[Stateful: Home page] Missing information of Store this API key section
first
time","number":198253,"url":"https://github.com/elastic/kibana/pull/198253","mergeCommit":{"message":"fix:
[Stateful: Home page] Missing information of Store this API key section
first time (#198253)\n\nCloses: #195382\r\nCloses: #195366\r\n\r\n##
Description\r\n\r\nAll information which is accessible for the user
should be announced\r\nwhen the user navigates to the element first time
(not only when he\r\nreaches it second, third and so on time).\r\n\r\n##
What was changed?:\r\n\r\n1. added `role=\"alert\"` to correctly
pronounce status update. Addind\r\nrole attribute also fixes
#195366\r\n\r\n\r\n##
Screen:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81","sha":"92ae754ff93b52b742885761afa8b2b7d857ce25"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198253","number":198253,"mergeCommit":{"message":"fix:
[Stateful: Home page] Missing information of Store this API key section
first time (#198253)\n\nCloses: #195382\r\nCloses: #195366\r\n\r\n##
Description\r\n\r\nAll information which is accessible for the user
should be announced\r\nwhen the user navigates to the element first time
(not only when he\r\nreaches it second, third and so on time).\r\n\r\n##
What was changed?:\r\n\r\n1. added `role=\"alert\"` to correctly
pronounce status update. Addind\r\nrole attribute also fixes
#195366\r\n\r\n\r\n##
Screen:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81","sha":"92ae754ff93b52b742885761afa8b2b7d857ce25"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
mgadewoll pushed a commit to mgadewoll/kibana that referenced this issue Nov 7, 2024
@alexwizp @mgadewoll
fix: [Stateful: Home page] Missing information of Store this API key …
f60be29 
…section first time (elastic#198253)

Closes: elastic#195382
Closes: elastic#195366

## Description

All information which is accessible for the user should be announced
when the user navigates to the element first time (not only when he
reaches it second, third and so on time).

## What was changed?:

1. added `role="alert"` to correctly pronounce status update. Addind
role attribute also fixes elastic#195366


## Screen:


https://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
defect-level-3 Moderate UX disruption or potentially confusing Project:Accessibility Team:Search WCAG A WCAG AA
Projects
None yet
Milestone
No milestone
3 participants
@elasticmachine @alexwizp @L1nBra