Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search: Indices page] Wrong navigation sequence after Reset or Save Default Settings #195942

Closed
L1nBra opened this issue Oct 11, 2024 · 4 comments · Fixed by #201163
Closed

[Search: Indices page] Wrong navigation sequence after Reset or Save Default Settings #195942

L1nBra opened this issue Oct 11, 2024 · 4 comments · Fixed by #201163
Assignees
@JoseLuisGJ
Labels
defect-level-3 Moderate UX disruption or potentially confusing impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Accessibility Team:Search WCAG A WCAG AA

Comments

@L1nBra
Copy link

L1nBra commented Oct 11, 2024 •
edited
Loading

Description
Navigation should be clear and in sequence for the user to easily understand how to navigate on the webpage.

Preconditions
Stateful Indices page is opened.
At least one index is added.
Use Screen Reader (NVDA).

Steps to reproduce

1.Navigate to Default settings button while using only keyboard by pressing Tab key.
2.Press Enter.
3.Navigate to any switch button inside the dialog window (f.e.: Content extraction switch).
4.Press Enter key on switch button
5.Navigate to Reset button while pressing Tab key.
6.Press Enter.
8.Observe page and Screen Reader announcement.

UI elements
Image

NVDA Speech Viewer
Image

Actual Result

  • After pressing Enter on Reset button, Screen Reader announces Default settings button, which is under the dialog window (on the main Indices page); no focus visible on any element; no announcement for the user that Reset was performed.
    Same behavior after pressing Enter key on Save button.

Expected Result

  • Focus shouldn't move outside of Default settings dialog. It should either
    a) be visible on the first element in the dialog window (close button or ingest pipelines link)
    or
    b) if after pressing Enter key on Reset button dialog window should close, then dialog closes and focus is visible on Default settings button.
    and user should be informed about the Reset being performed.

Meta Issue

Kibana Version: 8.16.0-SNAPSHOT

OS: Windows 11 Pro

Browser: Chrome Version 129.0.6668.70 (Official Build) (64-bit)

Screen reader: NVDA

WCAG or Vendor Guidance (optional)

Related to: https://github.com/elastic/search-team/issues/8256
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 11, 2024
@L1nBra L1nBra added WCAG A WCAG AA defect-level-3 Moderate UX disruption or potentially confusing Team:Search labels Oct 11, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 11, 2024
@L1nBra
Copy link
Author

L1nBra commented Oct 11, 2024

Similar to issue #195366 , only in this dialog additional content doesn't appear.

@L1nBra L1nBra added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Oct 17, 2024
@daveyholler
Copy link
Contributor

daveyholler commented Oct 22, 2024 •
edited
Loading

@DianaJourdan I've added this to the Search Experiences Extract & Transform team project

@L1nBra
Copy link
Author

L1nBra commented Oct 23, 2024

Same behavior observed on

  • Connectors page - Default settings button is announced after pressing Enter on Reset or Save button on the dialog.

NVDA speech viewer
Image

@L1nBra L1nBra changed the title [Stateful: Indices page] Wrong navigation sequence after Reset or Save Default Settings [Search: Indices page] Wrong navigation sequence after Reset or Save Default Settings Nov 7, 2024
@JoseLuisGJ JoseLuisGJ self-assigned this Nov 21, 2024
@JoseLuisGJ JoseLuisGJ linked a pull request Nov 21, 2024 that will close this issue
[Search][a11y] Fixing wrong navigation sequence after Reset or Save Default Settings #201163
Merged
@JoseLuisGJ JoseLuisGJ mentioned this issue Nov 22, 2024
Merged
JoseLuisGJ added a commit that referenced this issue Nov 22, 2024
@JoseLuisGJ
[Search][a11y] Fixing wrong navigation sequence after Reset or Save D…
56ee089 
…efault Settings (#201163)

## Summary

This PR solves the issues
#195951 and
#195942 getting the focus on the
first interactive element as suggested which is the _ingest pipelines_
external link after pressing enter using the keyboard navigation either
the _Reset_ or _Save_ buttons. With this the screen reader announces the
_ingest pipelines_ content after any of those previous events.

![CleanShot 2024-11-22 at 10 16
08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 22, 2024
@JoseLuisGJ
[Search][a11y] Fixing wrong navigation sequence after Reset or Save D…
12ccac1 
…efault Settings (elastic#201163)

## Summary

This PR solves the issues
elastic#195951 and
elastic#195942 getting the focus on the
first interactive element as suggested which is the _ingest pipelines_
external link after pressing enter using the keyboard navigation either
the _Reset_ or _Save_ buttons. With this the screen reader announces the
_ingest pipelines_ content after any of those previous events.

![CleanShot 2024-11-22 at 10 16
08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)

(cherry picked from commit 56ee089)
kibanamachine added a commit that referenced this issue Nov 22, 2024
@kibanamachine @JoseLuisGJ
[8.x] [Search][a11y] Fixing wrong navigation sequence after Reset or …
a8bd887 
…Save Default Settings (#201163) (#201404)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search][a11y] Fixing wrong navigation sequence after Reset or Save
Default Settings
(#201163)](#201163)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"José Luis
González","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T14:42:16Z","message":"[Search][a11y]
Fixing wrong navigation sequence after Reset or Save Default Settings
(#201163)\n\n## Summary\r\n\r\nThis PR solves the
issues\r\nhttps://github.com//issues/195951
and\r\nhttps://github.com//issues/195942 getting the focus
on the\r\nfirst interactive element as suggested which is the _ingest
pipelines_\r\nexternal link after pressing enter using the keyboard
navigation either\r\nthe _Reset_ or _Save_ buttons. With this the screen
reader announces the\r\n_ingest pipelines_ content after any of those
previous events.\r\n\r\n![CleanShot 2024-11-22 at 10
16\r\n08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)","sha":"56ee08946c1bead9d44829a9adfb11700522e70f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","accessibility:
keyboard navigation","backport:prev-minor"],"title":"[Search][a11y]
Fixing wrong navigation sequence after Reset or Save Default
Settings","number":201163,"url":"https://github.com/elastic/kibana/pull/201163","mergeCommit":{"message":"[Search][a11y]
Fixing wrong navigation sequence after Reset or Save Default Settings
(#201163)\n\n## Summary\r\n\r\nThis PR solves the
issues\r\nhttps://github.com//issues/195951
and\r\nhttps://github.com//issues/195942 getting the focus
on the\r\nfirst interactive element as suggested which is the _ingest
pipelines_\r\nexternal link after pressing enter using the keyboard
navigation either\r\nthe _Reset_ or _Save_ buttons. With this the screen
reader announces the\r\n_ingest pipelines_ content after any of those
previous events.\r\n\r\n![CleanShot 2024-11-22 at 10
16\r\n08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)","sha":"56ee08946c1bead9d44829a9adfb11700522e70f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201163","number":201163,"mergeCommit":{"message":"[Search][a11y]
Fixing wrong navigation sequence after Reset or Save Default Settings
(#201163)\n\n## Summary\r\n\r\nThis PR solves the
issues\r\nhttps://github.com//issues/195951
and\r\nhttps://github.com//issues/195942 getting the focus
on the\r\nfirst interactive element as suggested which is the _ingest
pipelines_\r\nexternal link after pressing enter using the keyboard
navigation either\r\nthe _Reset_ or _Save_ buttons. With this the screen
reader announces the\r\n_ingest pipelines_ content after any of those
previous events.\r\n\r\n![CleanShot 2024-11-22 at 10
16\r\n08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)","sha":"56ee08946c1bead9d44829a9adfb11700522e70f"}}]}]
BACKPORT-->

Co-authored-by: José Luis González <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this issue Nov 26, 2024
@JoseLuisGJ @paulinashakirova
[Search][a11y] Fixing wrong navigation sequence after Reset or Save D…
03284e8 
…efault Settings (elastic#201163)

## Summary

This PR solves the issues
elastic#195951 and
elastic#195942 getting the focus on the
first interactive element as suggested which is the _ingest pipelines_
external link after pressing enter using the keyboard navigation either
the _Reset_ or _Save_ buttons. With this the screen reader announces the
_ingest pipelines_ content after any of those previous events.

![CleanShot 2024-11-22 at 10 16
08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@JoseLuisGJ @CAWilson94
[Search][a11y] Fixing wrong navigation sequence after Reset or Save D…
8dab71d 
…efault Settings (elastic#201163)

## Summary

This PR solves the issues
elastic#195951 and
elastic#195942 getting the focus on the
first interactive element as suggested which is the _ingest pipelines_
external link after pressing enter using the keyboard navigation either
the _Reset_ or _Save_ buttons. With this the screen reader announces the
_ingest pipelines_ content after any of those previous events.

![CleanShot 2024-11-22 at 10 16
08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoseLuisGJ JoseLuisGJ

Labels
defect-level-3 Moderate UX disruption or potentially confusing impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Accessibility Team:Search WCAG A WCAG AA
Projects
None yet
Milestone
No milestone
5 participants
@daveyholler @JoseLuisGJ @elasticmachine @petrklapka @L1nBra