Skip to content

Commit

Permalink
[8.x] fix: [Stateful: Home page] Missing information of Store this AP…
Browse files Browse the repository at this point in the history
…I key section first time (#198253) (#199010)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Stateful: Home page] Missing information of Store this API key
section first time
(#198253)](#198253)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T15:38:26Z","message":"fix:
[Stateful: Home page] Missing information of Store this API key section
first time (#198253)\n\nCloses: #195382\r\nCloses: #195366\r\n\r\n##
Description\r\n\r\nAll information which is accessible for the user
should be announced\r\nwhen the user navigates to the element first time
(not only when he\r\nreaches it second, third and so on time).\r\n\r\n##
What was changed?:\r\n\r\n1. added `role=\"alert\"` to correctly
pronounce status update. Addind\r\nrole attribute also fixes
#195366\r\n\r\n\r\n##
Screen:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81","sha":"92ae754ff93b52b742885761afa8b2b7d857ce25","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix:
[Stateful: Home page] Missing information of Store this API key section
first
time","number":198253,"url":"https://github.com/elastic/kibana/pull/198253","mergeCommit":{"message":"fix:
[Stateful: Home page] Missing information of Store this API key section
first time (#198253)\n\nCloses: #195382\r\nCloses: #195366\r\n\r\n##
Description\r\n\r\nAll information which is accessible for the user
should be announced\r\nwhen the user navigates to the element first time
(not only when he\r\nreaches it second, third and so on time).\r\n\r\n##
What was changed?:\r\n\r\n1. added `role=\"alert\"` to correctly
pronounce status update. Addind\r\nrole attribute also fixes
#195366\r\n\r\n\r\n##
Screen:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81","sha":"92ae754ff93b52b742885761afa8b2b7d857ce25"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198253","number":198253,"mergeCommit":{"message":"fix:
[Stateful: Home page] Missing information of Store this API key section
first time (#198253)\n\nCloses: #195382\r\nCloses: #195366\r\n\r\n##
Description\r\n\r\nAll information which is accessible for the user
should be announced\r\nwhen the user navigates to the element first time
(not only when he\r\nreaches it second, third and so on time).\r\n\r\n##
What was changed?:\r\n\r\n1. added `role=\"alert\"` to correctly
pronounce status update. Addind\r\nrole attribute also fixes
#195366\r\n\r\n\r\n##
Screen:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81","sha":"92ae754ff93b52b742885761afa8b2b7d857ce25"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
  • Loading branch information
kibanamachine and alexwizp authored Nov 5, 2024
1 parent f312c1e commit 8ff526e
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ export const CreateApiKeyFlyout: React.FC<CreateApiKeyFlyoutProps> = ({ onClose
defaultMessage: 'Store this API key',
})}
titleSize="xs"
role="alert"
>
<EuiText>
{i18n.translate('xpack.enterpriseSearch.apiKey.apiKeyStepDescription', {
Expand Down

0 comments on commit 8ff526e

Please sign in to comment.