fix(slo): use correct uisettings #193362
Merged
fix(slo): use correct uisettings #193362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
kdelemme
added
backport
backport:prev-minor
botelastic
bot
added
the
ci:project-deploy-observability
shahzad31
reviewed
Sep 19, 2024
|
I did not change the showGood, showBad usage. Let me check |
|
I got them on the good bad event charts. Where did you click from? slo_good_bad_filter.mov |
|
@shahzad31 I guess it was never implemented for other than kql indicator: |
shahzad31
approved these changes
Sep 19, 2024
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @kdelemme |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 19, 2024
(cherry picked from commit 92b2c03)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 19, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [fix(slo): use correct uisettings (#193362)](#193362) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-19T17:23:55Z","message":"fix(slo): use correct uisettings (#193362)","sha":"92b2c0324779711b6c95b1f90027cef210401ce9","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","backport:prev-minor","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0"],"title":"fix(slo): use correct uisettings","number":193362,"url":"https://github.com/elastic/kibana/pull/193362","mergeCommit":{"message":"fix(slo): use correct uisettings (#193362)","sha":"92b2c0324779711b6c95b1f90027cef210401ce9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193362","number":193362,"mergeCommit":{"message":"fix(slo): use correct uisettings (#193362)","sha":"92b2c0324779711b6c95b1f90027cef210401ce9"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Sep 20, 2024
(cherry picked from commit 92b2c03) # Conflicts: # x-pack/plugins/observability_solution/slo/public/components/good_bad_events_chart/good_bad_events_chart.tsx # x-pack/plugins/observability_solution/slo/public/pages/slo_details/components/events_chart_panel.tsx # x-pack/plugins/observability_solution/slo/public/utils/slo/get_discover_link.ts
kdelemme
added a commit
that referenced
this pull request
Sep 25, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [fix(slo): use correct uisettings (#193362)](#193362) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-19T17:23:55Z","message":"fix(slo): use correct uisettings (#193362)","sha":"92b2c0324779711b6c95b1f90027cef210401ce9","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","backport:prev-minor","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0"],"number":193362,"url":"https://github.com/elastic/kibana/pull/193362","mergeCommit":{"message":"fix(slo): use correct uisettings (#193362)","sha":"92b2c0324779711b6c95b1f90027cef210401ce9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193362","number":193362,"mergeCommit":{"message":"fix(slo): use correct uisettings (#193362)","sha":"92b2c0324779711b6c95b1f90027cef210401ce9"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/193457","number":193457,"state":"MERGED","mergeCommit":{"sha":"0125a030f9055117476c4139d425cd112a43e0dc","message":"[8.x] fix(slo): use correct uisettings (#193362) (#193457)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [fix(slo): use correct uisettings\n(#193362)](https://github.com/elastic/kibana/pull/193362)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Kevin\nDelemme\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-09-19T17:23:55Z\",\"message\":\"fix(slo):\nuse correct uisettings\n(#193362)\",\"sha\":\"92b2c0324779711b6c95b1f90027cef210401ce9\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"backport\",\"release_note:skip\",\"v9.0.0\",\"backport:prev-minor\",\"backport:prev-major\",\"ci:project-deploy-observability\",\"Team:obs-ux-management\",\"v8.16.0\"],\"title\":\"fix(slo):\nuse correct\nuisettings\",\"number\":193362,\"url\":\"https://github.com/elastic/kibana/pull/193362\",\"mergeCommit\":{\"message\":\"fix(slo):\nuse correct uisettings\n(#193362)\",\"sha\":\"92b2c0324779711b6c95b1f90027cef210401ce9\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.x\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/193362\",\"number\":193362,\"mergeCommit\":{\"message\":\"fix(slo):\nuse correct uisettings\n(#193362)\",\"sha\":\"92b2c0324779711b6c95b1f90027cef210401ce9\"}},{\"branch\":\"8.x\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v8.16.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Kevin Delemme <[email protected]>"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #193337
Summary
This PR fixes a bug where the kibana settings were not used when building the ES query. I've also moved the chart component from the slos page folder into the common components folder.
This should be backported to 8.14 and 8.15