Removes kbn-std/unset as it's not used anywhere #193298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf
added
Team:Core
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-core (Team:Core) |
rudolf
added
the
backport:all-open
afharo
approved these changes
Sep 20, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 20, 2024
## Summary Removes unset as it's not used anywhere. Underscore includes an unset function which most plugins seem to prefer. (cherry picked from commit bddeac0)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2024
…193585) # Backport This will backport the following commits from `main` to `8.x`: - [Removes kbn-std/unset as it's not used anywhere (#193298)](#193298) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rudolf Meijering","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-20T13:44:52Z","message":"Removes kbn-std/unset as it's not used anywhere (#193298)\n\n## Summary\r\n\r\nRemoves unset as it's not used anywhere. Underscore includes an unset\r\nfunction which most plugins seem to prefer.","sha":"bddeac062a7fc1c87cacca0ef2c94ea2bd22f5c3","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:all-open"],"title":"Removes kbn-std/unset as it's not used anywhere","number":193298,"url":"https://github.com/elastic/kibana/pull/193298","mergeCommit":{"message":"Removes kbn-std/unset as it's not used anywhere (#193298)\n\n## Summary\r\n\r\nRemoves unset as it's not used anywhere. Underscore includes an unset\r\nfunction which most plugins seem to prefer.","sha":"bddeac062a7fc1c87cacca0ef2c94ea2bd22f5c3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193298","number":193298,"mergeCommit":{"message":"Removes kbn-std/unset as it's not used anywhere (#193298)\n\n## Summary\r\n\r\nRemoves unset as it's not used anywhere. Underscore includes an unset\r\nfunction which most plugins seem to prefer.","sha":"bddeac062a7fc1c87cacca0ef2c94ea2bd22f5c3"}}]}] BACKPORT--> Co-authored-by: Rudolf Meijering <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes unset as it's not used anywhere. Underscore includes an unset function which most plugins seem to prefer.