Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.15] fix(slo): use correct uisettings (#193362) #193575

Merged
merged 4 commits into from
Sep 25, 2024
Merged

[8.15] fix(slo): use correct uisettings (#193362) #193575

merged 4 commits into from
Sep 25, 2024

Conversation

kdelemme
Copy link
Contributor

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Kevin Delemme "}}]}] BACKPORT-->

@kdelemme
fix(slo): use correct uisettings (elastic#193362)
f142eda 
(cherry picked from commit 92b2c03)

# Conflicts:
#	x-pack/plugins/observability_solution/slo/public/components/good_bad_events_chart/good_bad_events_chart.tsx
#	x-pack/plugins/observability_solution/slo/public/pages/slo_details/components/events_chart_panel.tsx
#	x-pack/plugins/observability_solution/slo/public/utils/slo/get_discover_link.ts
@kdelemme kdelemme enabled auto-merge (squash) September 20, 2024 13:20
@kdelemme kdelemme mentioned this pull request Sep 20, 2024
Merged
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 20, 2024
@kdelemme kdelemme requested a review from a team September 20, 2024 13:21
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 25, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 2c70420
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193575-2c70420164a6

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 870.6KB 871.4KB +815.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
slo 24.3KB 24.4KB +134.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kdelemme kdelemme merged commit bb0b2c9 into elastic:8.15 Sep 25, 2024
23 checks passed
@kdelemme kdelemme deleted the backport/8.15/pr-193362 branch September 25, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryam-saeidi maryam-saeidi maryam-saeidi approved these changes

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kdelemme @obltmachine @kibana-ci @maryam-saeidi