[Cases] Fix flaky tests in the `CaseViewPage` component #172940

cnasikas · 2023-12-08T12:57:11Z

Summary

Tests:

renders tabs correctly: Moved to functional testing
renders the activity tab by default: Removed. It is being tested in functional testing
renders the activity tab when the query parameter tabId has activity: Moved to functional testing
renders the activity tab when the query parameter tabId has an unknown value: Moved to functional testing
navigates to the activity tab when the activity tab is clicked: Moved to functional testing
should show closed indicators in header when case is closed: Moved to x-pack/plugins/cases/public/components/case_action_bar/index.test.tsx
should push updates on button click: Moved to x-pack/plugins/cases/public/components/edit_connector/index.test.tsx
should disable the push button when connector is invalid: Moved to x-pack/plugins/cases/public/components/edit_connector/index.test.tsx
should show the rule name: Already tested in x-pack/plugins/cases/public/components/user_actions/comment/alert_event.test.tsx
should show the correct connector name on the push button: Moved to x-pack/plugins/cases/public/components/edit_connector/index.test.tsx
Callouts: Already tested in x-pack/plugins/cases/public/components/use_push_to_service/index.test.tsx
should display the alerts tab when the feature is enabled: Moved to x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx
should not display the alerts tab when the feature is disabled: Moved to x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx
should not show the experimental badge on the alerts table: Moved to x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx
should show the experimental badge on the alerts table: Moved to x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx
renders the alerts tab when the query parameter tabId has alerts: Unskip functional test
navigates to the alerts tab when the alerts tab is clicked: Removed. It is being tested in functional testing
shows the connectors in the sidebar: Removed. It is being tested in functional testing
shows the case action bar: Removed. It is being tested in functional testing
should show loading content when loading user actions stats: Removed. Already tested in x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx
should call show alert details with expected arguments: Removed. Already tested in x-pack/plugins/cases/public/components/user_actions/comment/comment.test.tsx
should show the case tabs: Moved to functional testing
should display description when case is loading: Moved to x-pack/plugins/cases/public/components/description/index.test.tsx
renders the description correctly: Removed. Already tested in x-pack/plugins/cases/public/components/description/index.test.tsx
should update settings: Removed. Already tested in x-pack/plugins/cases/public/components/case_action_bar/index.test.tsx

Fixes: #149778, #149777, #149776, #170532, #171718, #149771, #173136

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4862

Successful builds: https://buildkite.com/elastic/kibana-pull-request/builds?branch=cnasikas%3Afix_149777

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

cnasikas · 2023-12-08T13:40:05Z

x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx

-    describe('description', () => {
-      it('renders the description correctly', async () => {
-        appMockRenderer.render(<CaseViewPage {...caseProps} />);
+  describe('description', () => {


Moved outside the Tabs block.

cnasikas · 2023-12-08T13:41:31Z

x-pack/plugins/cases/public/components/case_view/case_view_page.tsx

-      }
-      return CASE_VIEW_PAGE_TABS.ACTIVITY;
-    }, [urlParams.tabId]);
+    const activeTabId = getActiveTabId(urlParams?.tabId);


When I removed some tests the other tests started failing. There was an issue with mocking and memorization that affected the tests. I removed the useMemo as it is redundant.

elasticmachine · 2023-12-08T13:53:40Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2023-12-08T13:53:42Z

Pinging @elastic/response-ops-cases (Feature:Cases)

cnasikas · 2023-12-08T13:55:04Z

x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts

+      it('renders tabs correctly', async () => {
+        await testSubjects.existOrFail('case-view-tab-title-activity');
+        await testSubjects.existOrFail('case-view-tab-title-files');
+        // there are no alerts in stack management yet


When this PR #172217 is merged we can test the alerts table in the stack.

cnasikas · 2023-12-08T14:14:31Z

buildkite test this

adcoelho · 2023-12-08T14:54:45Z

x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx

@@ -191,273 +200,218 @@ describe('CaseViewPage', () => {
    Object.defineProperty(window, 'getComputedStyle', originalGetComputedStyle);
  });

-  it('shows the metrics section', async () => {
-    appMockRenderer.render(<CaseViewPage {...caseProps} />);
+  for (let index = 0; index < 50; index++) {


Don't forget to remove this

adcoelho · 2023-12-08T14:56:58Z

x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts

      it('shows the "activity" tab by default', async () => {
        await testSubjects.existOrFail('case-view-tab-title-activity');
        await testSubjects.existOrFail('case-view-tab-content-activity');
      });

+      it("shows the 'activity' tab when clicked", async () => {


Does this test make sense here following the previous one?

We are already in the activity tab, I don't know how relevant it is to check that nothing changes when we click it.

Maybe we could go to files and back instead?

Good idea. Much better.

cnasikas · 2023-12-10T16:12:57Z

@elasticmachine merge upstream

cnasikas · 2023-12-10T17:39:37Z

@elasticmachine merge upstream

cnasikas · 2023-12-11T00:19:47Z

@elasticmachine merge upstream

cnasikas · 2023-12-11T00:21:45Z

/ci

cnasikas · 2023-12-11T09:43:51Z

/ci

cnasikas · 2023-12-12T22:59:35Z

@elasticmachine merge upstream

cnasikas · 2024-01-12T21:04:47Z

@elasticmachine merge upstream

kibana-ci · 2024-01-15T12:31:27Z

💚 Build Succeeded

Buildkite Build
Commit: f47d60f

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	445.1KB	445.1KB	+6.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`cases`	58	57	-1

Total ESLint disabled count

id	before	after	diff
`cases`	74	73	-1

History

💚 Build #187422 succeeded 63f5870
💔 Build #187384 failed 48537b8
💛 Build #187324 was flaky 20369ab
💔 Build #186748 failed fb92d1f
💔 Build #184486 failed 3ce63b4
💛 Build #184384 was flaky e6a3735

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

Fix flaky tests

29f9c5f

cnasikas self-assigned this Dec 8, 2023

cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.12.0 v8.13.0 labels Dec 8, 2023

cnasikas commented Dec 8, 2023

View reviewed changes

Run the test 50 times

e0c1198

cnasikas marked this pull request as ready for review December 8, 2023 13:53

cnasikas requested a review from a team as a code owner December 8, 2023 13:53

cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label Dec 8, 2023

cnasikas commented Dec 8, 2023

View reviewed changes

Remove exclusive suite

5cf170c

adcoelho reviewed Dec 8, 2023

View reviewed changes

adcoelho approved these changes Dec 8, 2023

View reviewed changes

cnasikas added 2 commits December 9, 2023 18:29

PR feedback

02b437b

Mock more hooks and use fake timers

d484379

cnasikas mentioned this pull request Dec 10, 2023

Fix the CaseViewPage flaky test #153392

Closed

9 tasks

cnasikas force-pushed the fix_149777 branch from b547fd8 to d484379 Compare December 10, 2023 12:22

Merge branch 'main' into fix_149777

b0840d2

Merge branch 'main' into fix_149777

d49e5de

Merge branch 'main' into fix_149777

da0d8ad

cnasikas linked an issue Dec 14, 2023 that may be closed by this pull request

Failing test: Jest Tests.x-pack/plugins/cases/public/components/case_view - CaseViewPage shows the metrics section #173136

Closed

cnasikas added 6 commits December 19, 2023 21:02

Mock use_push_to_service and move tests to a lower level

35745f8

Merge branch 'main' into fix_149777

e6a3735

Move tests to lower levels

46e537d

Run 50 times

3ce63b4

Merge branch 'main' into fix_149777

327d09d

Remove alerts tab testing

fb92d1f

cnasikas removed the v8.12.0 label Jan 10, 2024

kibanamachine and others added 5 commits January 12, 2024 16:04

Merge branch 'main' into fix_149777

20369ab

Mock components and move tests

fa64d23

Merge branch 'fix_149777' of github.com:cnasikas/kibana into fix_149777

44a611d

Merge branch 'main' into fix_149777

48537b8

Fix bad test subj in functional test

63f5870

cnasikas force-pushed the fix_149777 branch from 784ca20 to 63f5870 Compare January 15, 2024 10:09

Remove loop

f47d60f

cnasikas merged commit 5b8c212 into elastic:main Jan 15, 2024
21 checks passed

cnasikas deleted the fix_149777 branch January 15, 2024 12:56

kibanamachine added the backport:skip This commit does not require backporting label Jan 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] Fix flaky tests in the `CaseViewPage` component #172940

[Cases] Fix flaky tests in the `CaseViewPage` component #172940

cnasikas commented Dec 8, 2023 •

edited

Loading

cnasikas Dec 8, 2023

cnasikas Dec 8, 2023 •

edited

Loading

elasticmachine commented Dec 8, 2023

elasticmachine commented Dec 8, 2023

cnasikas Dec 8, 2023

cnasikas commented Dec 8, 2023

adcoelho Dec 8, 2023

adcoelho Dec 8, 2023

cnasikas Dec 8, 2023

cnasikas commented Dec 10, 2023

cnasikas commented Dec 10, 2023

cnasikas commented Dec 11, 2023

cnasikas commented Dec 11, 2023

cnasikas commented Dec 11, 2023

cnasikas commented Dec 12, 2023

cnasikas commented Jan 12, 2024

kibana-ci commented Jan 15, 2024

ESLint disabled line counts

Total ESLint disabled count

[Cases] Fix flaky tests in the CaseViewPage component #172940

[Cases] Fix flaky tests in the CaseViewPage component #172940

Conversation

cnasikas commented Dec 8, 2023 • edited Loading

Summary

Checklist

For maintainers

cnasikas Dec 8, 2023

Choose a reason for hiding this comment

cnasikas Dec 8, 2023 • edited Loading

Choose a reason for hiding this comment

elasticmachine commented Dec 8, 2023

elasticmachine commented Dec 8, 2023

cnasikas Dec 8, 2023

Choose a reason for hiding this comment

cnasikas commented Dec 8, 2023

adcoelho Dec 8, 2023

Choose a reason for hiding this comment

adcoelho Dec 8, 2023

Choose a reason for hiding this comment

cnasikas Dec 8, 2023

Choose a reason for hiding this comment

cnasikas commented Dec 10, 2023

cnasikas commented Dec 10, 2023

cnasikas commented Dec 11, 2023

cnasikas commented Dec 11, 2023

cnasikas commented Dec 11, 2023

cnasikas commented Dec 12, 2023

cnasikas commented Jan 12, 2024

kibana-ci commented Jan 15, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

[Cases] Fix flaky tests in the `CaseViewPage` component #172940

[Cases] Fix flaky tests in the `CaseViewPage` component #172940

cnasikas commented Dec 8, 2023 •

edited

Loading

cnasikas Dec 8, 2023 •

edited

Loading