Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/cases/public/components/case_view - CaseViewPage should show the rule name #171718

Closed
kibanamachine opened this issue Nov 22, 2023 · 2 comments · Fixed by #172940
Closed

Failing test: Jest Tests.x-pack/plugins/cases/public/components/case_view - CaseViewPage should show the rule name #171718

kibanamachine opened this issue Nov 22, 2023 · 2 comments · Fixed by #172940
Assignees
@cnasikas
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

A test failed on a tracked branch

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at it (/var/lib/buildkite-agent/builds/kb-n2-4-spot-a2e7227facda8d78/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx:281:3)
    at _dispatchDescribe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-a2e7227facda8d78/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:91:26)
    at describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-a2e7227facda8d78/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:55:5)
    at Object.describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-a2e7227facda8d78/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx:114:1)
    at Runtime._execModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-a2e7227facda8d78/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1430:24)
    at Runtime._loadModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-a2e7227facda8d78/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1013:12)
    at Runtime.requireModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-a2e7227facda8d78/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:873:12)
    at jestAdapter (/var/lib/buildkite-agent/builds/kb-n2-4-spot-a2e7227facda8d78/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at runTestInternal (/var/lib/buildkite-agent/builds/kb-n2-4-spot-a2e7227facda8d78/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-a2e7227facda8d78/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:444:34)

First failure: CI Build - 8.11
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Nov 22, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 22, 2023
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Nov 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 22, 2023
@cnasikas cnasikas added the Feature:Cases Cases feature label Nov 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas self-assigned this Dec 5, 2023
@cnasikas cnasikas mentioned this issue Dec 8, 2023
Merged
2 tasks
@cnasikas cnasikas linked a pull request Dec 8, 2023 that will close this issue
[Cases] Fix flaky tests in the CaseViewPage component #172940
Merged
2 tasks
cnasikas added a commit that referenced this issue Jan 15, 2024
@cnasikas @kibanamachine
[Cases] Fix flaky tests in the CaseViewPage component (#172940)
5b8c212 
## Summary

Tests:

- `renders tabs correctly`: Moved to functional testing
- `renders the activity tab by default`: Removed. It is being tested in
functional testing
- `renders the activity tab when the query parameter tabId has
activity`: Moved to functional testing
- `renders the activity tab when the query parameter tabId has an
unknown value`: Moved to functional testing
- `navigates to the activity tab when the activity tab is clicked`:
Moved to functional testing
- `should show closed indicators in header when case is closed`: Moved
to
`x-pack/plugins/cases/public/components/case_action_bar/index.test.tsx`
- `should push updates on button click`: Moved to
`x-pack/plugins/cases/public/components/edit_connector/index.test.tsx`
- `should disable the push button when connector is invalid`: Moved to
`x-pack/plugins/cases/public/components/edit_connector/index.test.tsx`
- `should show the rule name`: Already tested in
`x-pack/plugins/cases/public/components/user_actions/comment/alert_event.test.tsx`
- `should show the correct connector name on the push button`: Moved to
`x-pack/plugins/cases/public/components/edit_connector/index.test.tsx`
- `Callouts`: Already tested in
`x-pack/plugins/cases/public/components/use_push_to_service/index.test.tsx`
- `should display the alerts tab when the feature is enabled`: Moved to
`x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx`
- `should not display the alerts tab when the feature is disabled`:
Moved to
`x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx`
- `should not show the experimental badge on the alerts table`: Moved to
`x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx`
- `should show the experimental badge on the alerts table`: Moved to
`x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx`
- `renders the alerts tab when the query parameter tabId has alerts`:
Unskip functional test
- `navigates to the alerts tab when the alerts tab is clicked`: Removed.
It is being tested in functional testing
- `shows the connectors in the sidebar`: Removed. It is being tested in
functional testing
- `shows the case action bar`: Removed. It is being tested in functional
testing
- `should show loading content when loading user actions stats`:
Removed. Already tested in
`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`
- `should call show alert details with expected arguments`: Removed.
Already tested in
`x-pack/plugins/cases/public/components/user_actions/comment/comment.test.tsx`
- `should show the case tabs`: Moved to functional testing
- `should display description when case is loading`: Moved to
`x-pack/plugins/cases/public/components/description/index.test.tsx`
- `renders the description correctly`: Removed. Already tested in
`x-pack/plugins/cases/public/components/description/index.test.tsx`
- `should update settings`: Removed. Already tested in
`x-pack/plugins/cases/public/components/case_action_bar/index.test.tsx`



Fixes: #149778,
#149777,
#149776,
#170532,
#171718,
#149771,
#173136

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4862

Successful builds:
https://buildkite.com/elastic/kibana-pull-request/builds?branch=cnasikas%3Afix_149777

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnasikas cnasikas

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cases] Fix flaky tests in the CaseViewPage component cnasikas/kibana
3 participants
@cnasikas @elasticmachine @kibanamachine