Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Log Explorer] Add link to fall back to Discover #165220

Closed
weltenwort opened this issue Aug 30, 2023 · 3 comments · Fixed by #165464
Closed

[Log Explorer] Add link to fall back to Discover #165220

weltenwort opened this issue Aug 30, 2023 · 3 comments · Fixed by #165464
Assignees
@tonyghiani
Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0

Comments

@weltenwort
Copy link
Member

📓 Summary

Since the log explorer imposes restrictions on the indices that can be viewed, we want to offer a fall-back link, which allows the user to navigate to Discover, which doesn't have these restrictions nor the special affordances.

✔️ Acceptance criteria

  • There is a link in the top navigation bar, which brings the user to Discover such that...
    • Discover uses an ad-hoc data view that matches the one used by the Log Explorer.
    • Discover views the same time range.
    • Discover applies the same query and filter.
    • Discover shows the same columns.

🎨 Mock-ups

image
@weltenwort weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0 labels Aug 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@tonyghiani tonyghiani self-assigned this Aug 31, 2023
@tonyghiani
Copy link
Contributor

Looks like, when factoring out the DiscoverContainer, we lost the ability to customize the top nav menu entries, which affects this issue. I'll investigate the cause and open a new issue if necessary.

@weltenwort
Copy link
Member Author

weltenwort commented Aug 31, 2023 •
edited
Loading

Since we're our own app we can control the chrome directly. I think you're looking for setHeaderActionMenu on the core.application service. There is a HeaderMenuPortal utility built on top of that. Not sure if we need it, but maybe worth a look.

I'm not sure whether it'll work for serverless too, though.

@tonyghiani tonyghiani mentioned this issue Sep 1, 2023
Merged
@weltenwort weltenwort mentioned this issue Sep 1, 2023
Closed
tonyghiani added a commit that referenced this issue Sep 6, 2023
@tonyghiani @kibanamachine
[Log Explorer] Add Discover fallback link (#165464)
1c7ac5d 
## 📓 Summary

Closes #165220 

This PR introduces a new fallback link from the Log Explorer application
to Discover.

To correctly retrieve the details required to correctly navigate to
Discover with the used data view and filters, the LogExplorer component
accepts now a new `state$` behaviour subject as a property that can be
used to notify the consumers of any change from the internal state.


https://github.com/elastic/kibana/assets/34506779/c8176ef2-7a3b-4c7e-860a-450ba677412a

## 🧪 Test suite

```
↳ Observability Log Explorer
  ↳ Header menu
    ↳ should inject the app header menu on the top navbar
    ↳ Discover fallback link
      ↳ should render a button link
      ↳ should navigate to discover keeping the current columns/filters/query/time/data view
```

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
@gbamparop gbamparop added Feature:LogsExplorer Logs Explorer feature and removed Feature:Logs UI Logs UI feature labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyghiani tonyghiani

Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs Explorer] Add Discover fallback link tonyghiani/kibana
4 participants
@weltenwort @gbamparop @elasticmachine @tonyghiani