Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Explorer] Add Discover fallback link #165464

Merged
merged 23 commits into from
Sep 6, 2023

Conversation

tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Sep 1, 2023

📓 Summary

Closes #165220

This PR introduces a new fallback link from the Log Explorer application to Discover.

To correctly retrieve the details required to correctly navigate to Discover with the used data view and filters, the LogExplorer component accepts now a new state$ behaviour subject as a property that can be used to notify the consumers of any change from the internal state.

discover_fallback.mov

🧪 Test suite

↳ Observability Log Explorer
  ↳ Header menu
    ↳ should inject the app header menu on the top navbar
    ↳ Discover fallback link
      ↳ should render a button link
      ↳ should navigate to discover keeping the current columns/filters/query/time/data view

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tonyghiani tonyghiani added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes labels Sep 4, 2023
@tonyghiani tonyghiani changed the title [Logs+] Add Discover fallback link [Log Explorer] Add Discover fallback link Sep 4, 2023
@tonyghiani tonyghiani marked this pull request as ready for review September 4, 2023 18:09
@tonyghiani tonyghiani requested review from a team as code owners September 4, 2023 18:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@Kerry350 Kerry350 self-requested a review September 4, 2023 19:19
@tonyghiani
Copy link
Contributor Author

/oblt-deploy-serverless

Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @tonyghiani 👏

Code looks good, and the link works as expected.

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-only review. Discover type export LGTM. Also had a quick look at the other changes in o11y to make this work including use of the Discover locator, and they also LGTM 👍

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 6, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Security Investigations Cypress Tests #2 / Export timelines Exports a custom timeline template Exports a custom timeline template
  • [job] [logs] Serverless Security Investigations Cypress Tests #2 / Row renderers "before all" hook for "Row renderers should be enabled by default" "before all" hook for "Row renderers should be enabled by default"
  • [job] [logs] Serverless Observability Examples Tests / serverless examples UI Unified Field List Examples Field stats field distribution "before all" hook for "should return an auto histogram for numbers and top values"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityLogExplorer 32 36 +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 71 72 +1
logExplorer 3 6 +3
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
logExplorer 220.7KB 220.9KB +170.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
logExplorer 1 4 +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
logExplorer 5.5KB 6.0KB +437.0B
observabilityLogExplorer 8.7KB 11.5KB +2.8KB
total +3.2KB
Unknown metric groups

API count

id before after diff
discover 98 113 +15
logExplorer 3 6 +3
total +18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tonyghiani tonyghiani merged commit 1c7ac5d into elastic:main Sep 6, 2023
@tonyghiani tonyghiani deleted the 165220-add-discover-link branch September 6, 2023 10:30
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 6, 2023
@achyutjhunjhunwala achyutjhunjhunwala changed the title [Log Explorer] Add Discover fallback link [Logs Explorer] Add Discover fallback link Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Log Explorer] Add link to fall back to Discover
7 participants